Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#1103 makeorx.bat typo or not ?

4.1.2
closed
Mark Miesfeld
None
none
5
2012-09-07
2012-08-16
hex
No

Just wondering if this is a typo (marked o BOLD) in makeorx.bat
...
echo SVN_REVSION=%SVN_REV%>> oorexx.ver.incl
goto GENERATE_VERSION_FILE_DONE

:NOSVN
if exist oorexx.ver.incl (
for /F "eol=# delims== tokens=1,2,3*" %%i in (oorexx.ver.incl) do (
if %%i == ORX_BLD_LVL set BLD_NUM=%%j
if %%i == SVN_REVISION set SVN_REV=%%j
)
) else (
copy oorexx.ver oorexx.ver.incl 1>nul 2>&1
set SVN_REV=%BLD_NUM%
echo SVN_REVSION=%SVN_REV%>> oorexx.ver.incl
....

Discussion

  • Mark Miesfeld
    Mark Miesfeld
    2012-08-16

    It is a typo, but one that hasn't caused any problems so far. It would probably only cause a problem for someone trying to build a Windows installer from a source package on Windows, and even then it would just effect the name of the installer package.

    I'll commit a fix this evening.

     
  • And how about this - do you and I get notified of this? I have had the last few notifies for your test updates...

     
  • Hmmm.... yes I did get a notify email... but it had nothing at all inside it to say that it was me who made the update. Not useful.

     
  • Mark Miesfeld
    Mark Miesfeld
    2012-08-17

    Committed revision 8207. For 4.1.2 release
    Committed revision 8208. 4.1 fixes.

     


Anonymous


Cancel   Add attachments