ogmrip-svn patch Gentoo 64 intall

Help
in0giro
2011-08-06
2013-03-04
  • in0giro
    in0giro
    2011-08-06

    ahoy,

      according to portage, when trying to emerge ogmrip-svn, though it compiles fine, the install is aborted:

    * QA Notice: Package has poor programming practices which may compile
     *            fine but exhibit random runtime failures.
     * ogmrip-source-chooser-widget.c:210: warning: implicit declaration of function 'gtk_combo_box_new_text'
     * ogmrip-source-chooser-widget.c:234: warning: implicit declaration of function 'gtk_combo_box_append_text'
     * ogmrip-x264-options.c:302: warning: implicit declaration of function 'gtk_combo_box_append_text'
     * ogmrip-crop-dialog.c:294: warning: implicit declaration of function gtk_range_set_update_policy
     * ogmrip-profile-editor.c:644: warning: implicit declaration of function gtk_combo_box_remove_text
     * ogmrip-profile-editor.c:648: warning: implicit declaration of function gtk_combo_box_append_text
     * 
     * QA Notice: Package has poor programming practices which may compile
     *            but will almost certainly crash on 64bit architectures.
     * 
     * Function `gtk_combo_box_new_text' implicitly converted to pointer at ogmrip-source-chooser-widget.c:210
     * 
     *  Please file a bug about this at http://bugs.gentoo.org/
     *  with the maintaining herd of the package.
     * 
     * ERROR: media-video/ogmrip-svn-9999 failed:
     *   install aborted due to poor programming practices shown above
    

    i think it is a small issue of not having

    #include <gtk/gtk.h>
    

    in certain C files.  i made quick checkout, made the changes, and it seems to work now.  i created a patch file (first time, not sure if it is correct) and have it below (there seems to be no way to attach a file to this topic):

    Index: src/ogmrip-profile-editor.c
    ===================================================================
    --- src/ogmrip-profile-editor.c (revisione 2063)
    +++ src/ogmrip-profile-editor.c (copia locale)
    @@ -31,7 +31,9 @@
    
     #include <glib/gi18n.h>
     #include <glade/glade.h>
    +#include <gtk/gtk.h>
    
    +
     #define OGMRIP_GLADE_FILE "ogmrip" G_DIR_SEPARATOR_S "ogmrip-profile-editor.glade"
     #define OGMRIP_GLADE_ROOT "root"
    
    Index: src/ogmrip-crop-dialog.c
    ===================================================================
    --- src/ogmrip-crop-dialog.c    (revisione 2063)
    +++ src/ogmrip-crop-dialog.c    (copia locale)
    @@ -32,6 +32,7 @@
     #include <glib/gi18n.h>
     #include <glib/gstdio.h>
     #include <glade/glade.h>
    +#include <gtk/gtk.h>
    
     #define OGMRIP_GLADE_FILE "ogmrip" G_DIR_SEPARATOR_S "ogmrip-crop.glade"
     #define OGMRIP_GLADE_ROOT "root"
    Index: libogmrip-gtk/ogmrip-source-chooser-widget.c
    ===================================================================
    --- libogmrip-gtk/ogmrip-source-chooser-widget.c    (revisione 2063)
    +++ libogmrip-gtk/ogmrip-source-chooser-widget.c    (copia locale)
    @@ -41,6 +41,8 @@
    
     #include <glib/gi18n-lib.h>
    
    +#include <gtk/gtk.h>
    +
     #define OGMRIP_AUDIO_CHOOSER_WIDGET_GET_PRIVATE(o) \
       (G_TYPE_INSTANCE_GET_PRIVATE ((o), OGMRIP_TYPE_AUDIO_CHOOSER_WIDGET, OGMRipSourceChooserWidgetPriv))
    
    Index: libogmrip-gtk/ogmrip-x264-options.c
    ===================================================================
    --- libogmrip-gtk/ogmrip-x264-options.c (revisione 2063)
    +++ libogmrip-gtk/ogmrip-x264-options.c (copia locale)
    @@ -22,6 +22,7 @@
    
     #include <glib/gi18n.h>
     #include <glade/glade.h>
    +#include <gtk/gtk.h>
    
     #include "ogmrip-helper.h"
     #include "ogmrip-options-plugin.h"
    

    also note that one function

    gtk_range_set_update_policy
    

    seems to have been deprecated:

    gtk-range-set-update-policy

    please let me know if this diff  works and if/how i can integrate it into the SVN tree.

    peace, w

     
  • in0giro
    in0giro
    2012-12-21

    please ignore this patch/thread, i had no idea what i was talking about :)