#7 Update log with progress on SIGUSR1

closed
nobody
None
5
2014-03-28
2013-02-13
chilinux
No

The nwipe log file does not provide many details while the nwipe is running. It would be nice if the same information that is provided via the ncurses interface could be pushed into the log. My feature request is that if nwipe gets a SIGUSR1 then the information that would be provided in the statistics and main ncurses windows be dumped to the log.

Discussion

  • Andy Beverley
    Andy Beverley
    2013-02-13

    Would you be willing to work on the patch? It should be fairly easy: there is already a signal handler in nwipe.c (signal_hand), which could have code added to call nwipe_log.

    I can add at some point, but it's not a priority for me at the moment.

    Andy

     
  • chilinux
    chilinux
    2013-02-15

    Adds a logprogress.c/h files to be called at a SIGUSR1

     
    Attachments
  • chilinux
    chilinux
    2013-04-25

    Have you gotten a chance to review the patch? Is there any changes you need me to make before it can be merged into the main project?

     
  • Andy Beverley
    Andy Beverley
    2013-04-28

    Apologies - I didn't realise you'd submitted a patch.

    Thanks for sending it through. I've had a quick look, and on initial inspection it looks like a lot of the code is copied straight from gui.c? It would be better if the code was moved rather than copied, for better code maintainability (it's bad practice having exactly the same code repeated in a project).

    Also, the patch looks like it contains unnecessary files, such as logprogress.Po

    I'll have a better look in due course, but if in the meantime if you can look to move the logprogress code rather than copying it then that would be great.

    Thanks,

    Andy

     
  • Andy Beverley
    Andy Beverley
    2013-09-07

    I've implemented a reduced version of this feature, to be released in v0.15

     
  • Andy Beverley
    Andy Beverley
    2014-03-28

    • status: open --> closed
    • Group: --> Next Release (example)