#9 build macros for 0.13 doesn't handle curses lib correctly

closed-fixed
nobody
None
5
2013-02-14
2013-02-10
Michal Ambroz
No

Hello,
something in buikd macros for 0.13 is wrong in relation to ncurses library linking.
http://kojipkgs.fedoraproject.org//work/tasks/6248/4946248/build.log

I am not sure yet what is the issue exactly about, but it has something to do about the changes in the autoconf macros related to the pkg config.
I can see that no matter what I do the ncurses stays disabled in the config.h and as a result curses library is not linked in

config.h:
/* Define to 1 if you have the <ncurses.h> header file. */
/* #undef HAVE_NCURSES_H */

/* Define to 1 if you have the <ncurses/ncurses.h> header file. */
/* #undef HAVE_NCURSES_NCURSES_H */

As a result build fails.

Please can you have a look ?

Build of version 0.12 if fine and without problems:
https://koji.fedoraproject.org/koji/buildinfo?buildID=382378
After running ./config in version 0.12 the ncurses is enabled in config.h
/* Define to 1 if you have the <ncurses.h> header file. */
#define HAVE_NCURSES_H 1

Best regards
Michal Ambroz

Discussion

1 2 3 > >> (Page 1 of 3)
  • Michal Ambroz
    Michal Ambroz
    2013-02-10

    Patch the configure.ac to detect ncurses flags independently from panel.

     
  • Andy Beverley
    Andy Beverley
    2013-02-10

    Hmmm, strange. I can see why it would fail, but it works for me for some reason.

    Since 0.13 the ncurses libraries are checked by pkgconfig, which was a recently submitted patch. I'll see if either the submitter or I can take a look.

     
  • Alon Bar-Lev
    Alon Bar-Lev
    2013-02-13

    Hi,
    Can you please attach config.log?
    Thanks!

     
  • Alon Bar-Lev
    Alon Bar-Lev
    2013-02-13

    Can you also attach your /usr/lib/pkgconfig/panel.pc ?

     
  • Michal Ambroz
    Michal Ambroz
    2013-02-14

    Hi alonbl, abeverley,
    I obviously forgot to attach the patch. This one works for me (Fedora rawhide, F19, F18)
    It splits the detection of panel and ncurses so it is no longer exclusive option one or another, but both can be found at the same time.
    Michal Ambroz

     
  • Michal Ambroz
    Michal Ambroz
    2013-02-14

    nwipe-0.13-configure.patch

     
  • This patch should not be needed as the panel pkg-config file should include ncurses dependencies. Please attach the panel pkg-config file you have, there is something wrong there.

     
  • Michal Ambroz
    Michal Ambroz
    2013-02-14

    My pkg-config says :
    $pkg-config --cflags panel

    $ pkg-config --libs panel
    -lpanel

    $pkg-config --cflags ncurses

    $ pkg-config --libs ncurses
    -lncurses

    ==============================
    $ cat /usr/lib64/pkgconfig/panel.pc
    # vile:makemode

    prefix=/usr
    exec_prefix=/usr
    libdir=/usr/lib64
    includedir=/usr/include
    major_version=5
    version=5.9.20121017

    Name: panel
    Description: ncurses 5.9 add-on library
    Version: ${version}
    URL: http://invisible-island.net/ncurses
    Requires.private: ncurses, tinfo
    Libs: -L${libdir} -lpanel
    Libs.private:
    Cflags:
    [mambroz@mixer wrk]$ rpm -qf /usr/lib64/pkgconfig/panel.pc
    ncurses-devel-5.9-7.20121017.fc18.x86_64

     
  • Michal Ambroz
    Michal Ambroz
    2013-02-14

    config.log

     
    Attachments
  • Michal Ambroz
    Michal Ambroz
    2013-02-14

    Attached config.log when running without patch.

     
1 2 3 > >> (Page 1 of 3)