Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#7 wireless patch from Matteo Rosi

open
nobody
ns-2 (14)
5
2006-07-05
2006-07-05
Tom Henderson
No

ns-2 802.11 users,
> Matteo Rosi and Leonardo Maccari have contributed the
following patch to
> 802.11:
>
http://mailman.isi.edu/pipermail/ns-developers/2006-June/002298.html
>
> This is the original synopsis:
>
http://mailman.isi.edu/pipermail/ns-developers/2006-May/002290.html
>
> I am soliciting feedback on including this patch
(yes/no & rationale),
> since we do not have an 802.11 maintainer. Please
send replies to
> ns-developers list, or to me (I will repost on
ns-developers) if you are
> an ns-users subscriber who does not subscribe to
ns-developers.

Discussion

  • Tom Henderson
    Tom Henderson
    2006-07-05

    Logged In: YES
    user_id=1188103

    Comment from Mathieu:

    1) I wonder what is the use-case for this: is it used to
    simulate
    wireless networks in isolation ?
    2) Someone needs to remove all the "ModLart" tags (it would
    make sense
    for the authors to do so rather than leave this tedious work
    to you or
    someone else). I also noticed some dead code such as this:

    @@ -564,6 +606,20 @@
    void
    Mac802_11::backoffHandler()
    {
    +//ModLart 05/23/06 17:12
    + if(check_pktBEACON() == 0)
    + return;
    +//ModLart 05/30/06 15:03
    +// if(pktARS_) { // ???
    +// assert(mhSend_.busy() || mhDefer_.busy());
    +// return;
    +// }
    + if(check_pktASSOCRES() == 0)
    + return;
    +//ModLart 05/30/06 15:03
    + if(check_pktASSOCREQ() == 0)
    + return;
    +
    if(pktCTRL_) {
    assert(mhSend_.busy() || mhDefer_.busy());

    or this:

    @@ -518,6 +527,10 @@
    $netif propagation $pmodel ;# Propagation Model
    $netif node $self ;# Bind node <---> interface
    $netif antenna $ant_($t)
    +
    +# //LartMod 18/05/2006
    +# $netif update-mac
    +

    Either any code commented-out should be removed or a large
    comment block
    should be added to explain what it does and why it is there.

    3) tcl/ex/lart-semplicecollege4.tcl should be renamed to a more
    meaningful name such as tcl/ex/ibss-80211.tcl

    Provided the issues 2) and 3) are resolved, preferably by
    the patch
    authors (which would show their willingness to fix this ap
    code if it
    breaks unexpectedly), I guess it makes sense to add the
    feature. So:

    Yes: +1