#70 Dialogue Item "Don't check at launch time" wrong handled

Next_release
closed
Don HO
None
8
2008-12-15
2008-04-09
FLS
No

In the Settings - Preferences - MISC dialogue the item "Don't check at
launch time" is not correctly handled.
The visible effect is, that a ticked checkbox seems not to be stored in
the config.xml file. The checkbox is always disabled when restarted Npp.
However, when the checkbox is ticked and then un-ticked, the checkbox is
ticked when restarting Npp the next time.

Patch:
----------
This wrong behaviour is due to a missing negation of the checkbox variable
nppGUI._checkHistoryFiles. To correct this:

in file preferenceDlg.cpp about line 537 change the following

case IDC\_CHECK\_DONTCHECKHISTORY:
    nppGUI.\_checkHistoryFiles = isCheckedOrNot\(IDC\_CHECK\_DONTCHECKHISTORY\);
    //::SendMessage\(\_hParent, WM\_COMMAND, IDM\_SETTING\_HISTORY\_DONT\_CHECK, 0\);
    return TRUE;

to
case IDC_CHECK_DONTCHECKHISTORY:
nppGUI._checkHistoryFiles = !isCheckedOrNot(IDC_CHECK_DONTCHECKHISTORY);
//::SendMessage(_hParent, WM_COMMAND, IDM_SETTING_HISTORY_DONT_CHECK, 0);
return TRUE;

by just inserting a negation in the second line.

FLS

Discussion

  • Don HO
    Don HO
    2008-08-01

    • priority: 5 --> 8
    • assigned_to: nobody --> donho
     
  • Don HO
    Don HO
    2008-12-15

    • status: open --> closed