#545 Bugfix for #4493 - flickering with word wrap

Next_release
closed
nobody
None
7
2014-01-03
2013-12-19
Neomi
No

Bug #4493 describes a situation which causes strong flickering as a side effect of a patch I made some time ago (margin width adjusted correctly for line numbers even with folding enabled).

Basically, if the margin needs to grow to accommodate more digits, the edit area gets smaller. If lines happen to be just long enough that they now need to be wrapped (only with word wrapping turned on), the lines at the bottom with more digits are scrolled out of sight. This then results in the margin shrinking again, giving more space to the edit area. Then the long lines no longer need to be wrapped, lines with longer line numbers get to be visible again and the margin needs to grow. An endless cycle follows...

This patch fixes this problem. If word wrap is turned on, it determines the largest line number that would have to be displayed if no line was actually wrapped. The margin width is calculated for that line and remains stable.

1 Attachments

Discussion

  • Don HO
    Don HO
    2013-12-22

    I tried to reproduce the flicker with the provided instructions, but I see nothing serious. A video will be helpful.

    Don

     
    • Neomi
      Neomi
      2013-12-23

      I posted further information to reproduce this bug and an animated GIF that shows the result into the bug report.

       
      • Don HO
        Don HO
        2013-12-24

        Thank you Noemi.

        The patch is in trunk and this bug fix will be in the next release.

        Don

         
  • Don HO
    Don HO
    2013-12-24

    • status: open --> accepted
    • Priority: 5 --> 7
     
  • Don HO
    Don HO
    2014-01-03

    • status: accepted --> closed