#538 Function Help Buffer Overrun

Next_major_release
closed
nobody
None
7
2013-12-15
2013-11-08
JimD
No

There is a buffer overflow when you have function help enabled and type a "(" or otherwise try to get function help on a line having between 106 and 128 characters. The fix for this is in the attached ScintillaEditView.patch file.

Also, not providing function help for lines that are longer than 128 characters seems a bit limiting. Bumping this to 256 would be nice. In FunctionCallTip.cpp, function getCursorFunction, increase the value of "const int maxLen" to 256.

Thanks for maintaining such a great editor!!

1 Attachments

Discussion

  • Don HO
    Don HO
    2013-11-27

    • status: open --> accepted
    • Priority: 5 --> 7
     
  • Don HO
    Don HO
    2013-11-27

    The buffer will be increased from 128 to 256.
    Thank you for your patch.

    Don

     
  • Don HO
    Don HO
    2013-12-15

    • Status: accepted --> closed