Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#494 Fix for bugs #3719, #3479, #3401, ... (line number margin)

Next_release
closed
nobody
None
7
2013-08-29
2013-07-05
Neomi
No

This patch fixes bugs #3719, #3479, #3401, #3104, #2658, #2612, #2552 (basically duplicates) and maybe some more that I didn't find with the term "line number".

In version 6.4.1 when sections of text are folded, f.e. in a large XML file, the margin width for the line number display is calculated based on the last line's number in the visible set, not in the document. This small patch fixes that.

1 Attachments

Discussion

  • Neomi
    Neomi
    2013-07-05

    And here is a generated XML file (1.34 MB extracted) that shows the problem (fold "a" elements) and that the fix works.

     
    Attachments
  • FLS
    FLS
    2013-07-08

    Please note also patch #475 for similar bugfixing in updateLineNumberWidth() for fixing comparable but additional odd effects with line number column.

    FLS

     
  • Neomi
    Neomi
    2013-07-12

    Basically the same 3 line patch as before, but now I set up SVN and generated the patch relative to the current revision (1078). The last one was generated with WinMerge and therefore probably couldn't be applied directly in SVN.

     
  • Neomi
    Neomi
    2013-07-21

    This patch is obsolete now since it is part of patch #509.

    Edit: wrong, this patch is no longer obsolete since I introduced a regression in patch #509 and it had to be rejected.

     
    Last edit: Neomi 2013-08-05
  • Don HO
    Don HO
    2013-08-04

    • status: open --> closed
    • Priority: 5 --> 1
     
    • Neomi
      Neomi
      2013-08-05

      Hi Don,
      would you please consider accepting this patch again? Since I put that stupid little regression into #509, my previous statement about this one being obsolete was wrong. Thanks.

       
      • FLS
        FLS
        2013-10-04

        Hi Neomi
        Just note bug http://sourceforge.net/p/notepad-plus/bugs/4493/: Line number pane size adaptation causes text flickering.

        FLS

         
  • Don HO
    Don HO
    2013-08-06

    • status: closed --> accepted
    • Priority: 1 --> 7
     
  • Don HO
    Don HO
    2013-08-06

    Committed in SVN (Rev. 1100) and will be included in the next release.
    Thank you for the fix.

    Don

     
  • Don HO
    Don HO
    2013-08-29

    • status: accepted --> closed