#44 Fullscreen chooses proper monitor

closed
Don HO
None
9
2008-01-14
2008-01-10
Harry
No

Patch alters fullscreen behaviour (again ;)), so the right monitor should be chosen according to the current position of the window.
Me not having dual monitors, once again I can't fully test it, but I can guarantee it will not work on windows 95 (Notepad++ probably wont even run). I'm not sure if that OS is even supported by Notepad++ but I thought I would just mention it. From 98 onwards it should be fine.

Discussion

  • Harry
    Harry
    2008-01-10

    Fullscreen patch

     
  • Don HO
    Don HO
    2008-01-12

    Logged In: YES
    user_id=916327
    Originator: NO

    It doesn't work entirely on my 3 displays.
    I set my 2nd (the center one) display as the main display, in which there is the Start Menu.
    The 1st display (the left one) and the 3rd display (the right one) are the extension of the center one.

    With your patch, when Notepad++ is on the center display or the right one, hitting F11 works fine.
    However, if Notepad++ is on the 1st one (the left display), it makes Notepad++ invisible after F11.

    Any idea to remedy this problem?

    Don

     
  • Harry
    Harry
    2008-01-12

    Logged In: YES
    user_id=1831293
    Originator: YES

    I guess its that negative coordinates thing that keeps getting mentioned. I would have thought the values for the size of the monitor would be directly applicable to the window dimensions, but I guess not. I have a pretty good idea what might cause the behaviour, I will see if I can get a dual monitor setup somehow to try it out.

     
  • Don HO
    Don HO
    2008-01-12

    Logged In: YES
    user_id=916327
    Originator: NO

    Here is more track from config.xml (the npp closing position on upper-left corner ), it may help :
    the 1st (left) display :
    <GUIConfig name="AppPosition" x="-1600" y="2" width="931" height="783" isMaximized="no" />

    the 2nd (center) display on upper-left corner :
    <GUIConfig name="AppPosition" x="-1" y="1" width="931" height="783" isMaximized="no" />

    the 3rd (right) display on upper-left corner :
    <GUIConfig name="AppPosition" x="1600" y="1" width="931" height="783" isMaximized="no" />

    Hope it helps

    Don

     
  • Harry
    Harry
    2008-01-12

    Logged In: YES
    user_id=1831293
    Originator: YES

    New patch should fix the negative value handling (its that one big mistake I tend to make with RECTs, taking the coordinates instead of sizes).

    It took me a while to find a second suitable monitor to try it out, then some more to find a good cable ;).
    I moved the monitor in many corners and it kept working so I think it should be stable
    File Added: fullscreen_handle_negative.diff

     
  • Harry
    Harry
    2008-01-12

    New fullscreen patch

     
  • Don HO
    Don HO
    2008-01-12

    • priority: 5 --> 9
    • assigned_to: nobody --> donho
     
  • Don HO
    Don HO
    2008-01-12

    Logged In: YES
    user_id=916327
    Originator: NO

    > New patch should fix the negative value handling

    Indeed, it works now.
    It'll be in v4.7.4

    > It took me a while to find a second suitable monitor to try it out,
    > then some more to find a good cable ;).

    At least you have 3 displays either :)

    Thank you for your fine fix.

    Don

     
  • Don HO
    Don HO
    2008-01-14

    • status: open --> closed