#137 REBARBANDINFO for compilers > v6

Unstable_(example)
closed
Don HO
None
7
2009-06-07
2009-06-05
Thell Fowler
No

Patch to force the use of REBARBANDINFO_V3_SIZE allowing using more selection choices of which compiler to use without having to alter the core code.

Confirmed on VS2008 Express. Need confirmation on other versions. Especially VS2005.

Discussion

  • Thell Fowler
    Thell Fowler
    2009-06-05

    REBARBANDINFO_V3_SIZE

     
    Attachments
  • Tested on VS2005pro. Works fine. This build environment worked before the fix too, so it hasn't broken anything on working environments. Incremental search works too.

     
  • That look *terribly* dangerous as this is NOT the actual size of the struct!!!
    Isn't it possible to use the actual V3 struct insteaf?

     
  • Thell Fowler
    Thell Fowler
    2009-06-06

    joleg74,

    Interestingly enough using REBARBANDINFO_V6_SIZE worked on v9 compile as well. Now that we have have conf of v6 in vs2005 working with this we'll need to get a check of using the REBARBANDINFO_V6_SIZE. If that also works on a v6 compile, then I figure we can have a runtime check of the commctrl dll in use and use the appropriate stuct size for the dll in use.

     
  • Don HO
    Don HO
    2009-06-07

    The final solution is checking on the runtime :
    if (win version where notepad++ is executing is smaller/equal than win ME)
    __use sizeof(REBARBANDINFO)
    else
    __user REBARBANDINFO_V3_SIZE

    Note that V6 is not used since using V3 solves the current problem.
    My aim is to get compiling correctly for peoples who use vs 2008.
    The official binary release will stick on vs 2005, on which the binary generated correctly by using sizeof(REBARBANDINFO).

    Don

     
  • Don HO
    Don HO
    2009-06-07

    • status: open --> closed
    • priority: 5 --> 7
    • assigned_to: nobody --> donho