Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#86 Use Vendor abbrevs to enhance node display in device port view

closed
2014-01-26
2011-07-30
J R Binks
No

Making use of the vendor abbreviations created using my previous patch submission 3376779

https://sourceforge.net/tracker/?func=detail&aid=3376779&group_id=80033&atid=558510

the attached patch modifies the display of nodes in device.html to provide the option to replace the OUI part of the MAC address with the vendor abbreviation, in much the same way as Wireshark does. The feature can be toggled on and off through "Change View". A browser tooltip will display the full MAC address where required. Default is for the option to be off, but in my environment I'd probably want it on most of the time, so consideration could be given either to defaulting the option on in device.html, or perhaps permitting the administrator to select the default setting via netdisco.conf.

I think this patch is against my branch which includes my previous patch, if my git-foo is right. Or maybe not! (see comments on my git naiivity in previous patch).

Discussion

  • J R Binks
    J R Binks
    2011-07-30

     
    Attachments
  • J R Binks
    J R Binks
    2011-08-08

    Just to note that something's not quite with the above or the previous on which it relies, so hold back looking at it until I get time to track it down.

     
  • Eric A. Miller
    Eric A. Miller
    2014-01-26

    Ticket moved from /p/netdisco/patches/32/

    Can't be converted:

    • _milestone:
    • _priority: 5
     
  • Eric A. Miller
    Eric A. Miller
    2014-01-26

    • labels: Netdisco --> Netdisco, Feature
    • summary: Use Vendor abbrevs to enhance node display in device.html --> Use Vendor abbrevs to enhance node display in device port view
    • status: open --> new
    • assigned_to: Eric A. Miller
     
  • Eric A. Miller
    Eric A. Miller
    2014-01-26

    This has been implemented in Netdisco 2 in Commit 316e37. This doesn't replace the OUI portion of the MAC as in the attached patch, instead it adds the vendor abbreviation tagged with "Vendor:" behind each node if the Vendor Node Properties is checked. We can re-visit if it is still desired to modify the presentation of the MAC.

    Default setting is off, however, Netdisco 2 stores a cookie with the view preferences so a configuration option should no longer be necessary.

     
  • Eric A. Miller
    Eric A. Miller
    2014-01-26

    • status: new --> closed