Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#570 utility ad broken in version 3.1.2

None
closed
nobody
None
1
2014-06-24
2014-06-18
gaaronk
No

Hi!

Patch from bug #563 breaks utility ad.

For example, when I was try to remove file with this command:

ad rm /opt/rtorrent_0.9.2-2.dsc

I get this error:

Jun 18 06:48:45.641528 ad[16657] {netatalk_conf.c:1647} (E:Default): getvolbypath("/opt/rtorrent_0.9.2-2.dsc"): no volume for path
Segmentation fault

And in the log file:

Jun 18 06:48:45 debian ad[16657]: getvolbypath("/opt/rtorrent_0.9.2-2.dsc")
Jun 18 06:48:45 debian ad[16657]: getvolbypath: path("/opt/rtorrent_0.9.2-2.dsc") != volume("/opt")

Here is my 'minimal' config file

================
;
; Netatalk 3.x configuration file
;
[Global]
; Global server settings
hostname = "debian"
uam list = uams_dhx2.so

[opt]
path = /opt/
appledouble = ea
convert appledouble = no
cnid scheme = dbd
================

I think, this is because of incorrect use of strcmp.

This is because the function compares volume path and absolute file path, they will never match.

Discussion

  • gaaronk
    gaaronk
    2014-06-18

    [delete]

     
    Last edit: gaaronk 2014-06-21
  • gaaronk
    gaaronk
    2014-06-20

    Hello!

    Can you please review this patch ?

     
    Last edit: gaaronk 2014-06-21
    Attachments
  • Ralph Böhme
    Ralph Böhme
    2014-06-24

    • status: open --> closed
    • Group: -->