#2562 Windows x64 build broken on 5.7.3.pre4

[Jeff Gehlbach]

Building with build.bat on Windows 20008R2 x64 with Visual Studio 2012 (net-snmp-config.h attached) is broken (make.out also attached).

Build works with 5.7.3.pre3 with same options selected.

[Jeff Gehlbach]

Attaching net-snmp-config.h

[Bill Fenner]

Does this fix your build:

--- a/agent/mibgroup/ucd-snmp/pass_persist.c
+++ b/agent/mibgroup/ucd-snmp/pass_persist.c
@@ -722,11 +722,13 @@ close_persist_pipe(int iindex)
 #endif

     if (persist_pipes[iindex].pid != NETSNMP_NO_SUCH_PROCESS) {
+#ifdef SIGKILL
         /*
          * kill the child, in case we got an error and the child is not
          * cooperating.  Ignore the return code.
          */
         (void)kill(persist_pipes[iindex].pid, SIGKILL);
+#endif
 #if HAVE_SYS_WAIT_H
         waitpid(persist_pipes[iindex].pid, NULL, 0);
 #endif

[Jeff Gehlbach]

Fix identified by rstory:

15:52 < rstory-work> try wrapping the kill in pass_persist.c in a #ifdef HAVE_SIGNAL
16:00 < jeffg> rstory-work, w00t! that change alone unhorked it.

git patch attached.

[Jeff Gehlbach]

@Bill, it probably does -- seems you and rstory arrived independently at equivalent suggestions :)

Thanks!

[Jeff Gehlbach]

BTW the patch above is against a branch cut from V5-7-patches.

[Bill Fenner]

Pushed your fix db1f217541e00b53813d94f6befb9a42d4838e95 to 5-7-patches. Thanks!

[Robert Story]

patch applied, closing...