#64 Check for real changes of ext. mod files

development
closed-accepted
Eddy De Greef
Program (79)
5
2002-09-25
2002-08-30
No

With this patch nedit checks for real file contens
changes when the file timestamp changed. If the contens
isn't changed the warning "file has been modified by
another program ..." is omitted.

Patch against cvs as of 2002/08/30.

Warning: Based on an older version of the function
CheckForChangesToFile.

Markus Schwarzenberg

Discussion

  • cvs diff -c > check-file-mod.diff

     
    Attachments
  • Eddy De Greef
    Eddy De Greef
    2002-09-20

    • labels: --> Program
    • milestone: --> development
    • assigned_to: nobody --> edg
     
  • Eddy De Greef
    Eddy De Greef
    2002-09-20

    Improved version - updated to cvs HEAD

     
  • Eddy De Greef
    Eddy De Greef
    2002-09-20

    Logged In: YES
    user_id=73597

    I've attached an updated version of the path. It has some
    improvements and bug fixes:
    - It's updated to match current cvs HEAD
    - The DOS and Unix/Mac file comparison have been merged
    - memcmp is replaced by strncmp (memcmp is not POSIX)
    - there's no more encapsulation breakage (file.c accessing
    internals of textBuf)
    - bug fix: 0-characters were not taken into account
    - return values of comparison function were inconsistent
    with comments (BufCmp doesn't use same convention) ->
    simplified.
    - contents comparison is now a preference: Warnings->Check
    File Contents, default = On
    - help has been updated (new preference)

    Markus, if you have time, can you have a look at it to see
    whether I haven't made any mistakes ? Thanks.

     
  • Logged In: YES
    user_id=81393

    Thanks, Eddy.

    Your improvements look really good. I also did some basic
    tests, everything worked as expected. From my point of view
    this version is ready for commiting.

     
  • Eddy De Greef
    Eddy De Greef
    2002-09-25

    Logged In: YES
    user_id=73597

    The patch is committed, with one addition: a mode message
    appears if the comparison takes more than one 1 second.

     
  • Eddy De Greef
    Eddy De Greef
    2002-09-25

    • status: open --> closed-accepted