#46 single window help with history

development
closed
Eddy De Greef
Program (79)
5
2002-05-06
2002-03-07
No

This patch modifies the nedit 5.3 help system to reuse
an existing help window when following links in the
help system.

Additional windows can be created by using Btn2 to
follow the link. As already implemented in the current
help system, there are never duplicate windows for the
same help topic, that means following a link to an
existing help topic window always tops that window.
A second help window is created too (please tell your
opinions if this should be changed) if there is already
a help window and a currently not displayed help topic
is selected from the NEdit help menu, that means
windows are reused only for following links inside the
help windows and the prev/next buttons.

A simple navigation history is implemented: every help
topic window which has been reached following a link
remembers the source (and vice versa).

There are for small text only navigation buttons
(freaks are invited to create pixmaps... ;-)
<< history backward
<+ previous help topic (not affecting the history)
-> next help topic (not affecting the history)
>> history forward

Markus Schwarzenberg

Discussion

<< < 1 2 3 (Page 3 of 3)
  • Logged In: YES
    user_id=81393

    OK, here is the same patch (help_one_window_05.diff) but
    diffed against BETA-5-3.
    The patch file is help_one_window_05-BETA-5-3.diff.

     
  • Eddy De Greef
    Eddy De Greef
    2002-03-18

    Logged In: YES
    user_id=73597

    Thank you.
    There's one problem, though: when the text pane has the
    focus, Enter and Escape are not recognized any more (both
    of them should dismiss the window, because the Dismiss
    button is highlighted when the text widget has the focus).

    I guess it's just a matter of adding additional key bindings,
    as you did for Tab.

     
  • Logged In: YES
    user_id=81393

    OK. Now (help_one_window_06-BETA-5-3) we have:
    help-button-action(&lt;button-widget-name&gt;).

    The required argument must have one of the following values:
    &quot;find&quot;, &quot;findAgain&quot;, &quot;print&quot;, &quot;dismiss&quot;,
    &quot;prevTopic&quot;, &quot;nextTopic&quot;, &quot;histBack&quot;, &quot;histForw&quot;
    -- these are just the widget names of the buttons.

    Return and osfCancel are bound by default to:
    help-button-action(&quot;dismiss&quot;)

    Perhaps we should also bind Ctrl+F to
    help-button-action(&quot;find&quot;) ? ... and so on ...
    But since we still have the Alt-... accelerators I left the
    other unbound for now.

    Now the text pane gets the initial keyboard focus. I think
    that's the more expected behavior, thus people can
    immediately start navigating the help text.

    Markus Schwarzenberg

     
  • Eddy De Greef
    Eddy De Greef
    2002-03-18

    Logged In: YES
    user_id=73597

    Much better, thank you.
    One more nit: there's no visual indication as to where
    the current focus is (except for the cursor, which is
    hard to see). It would probably be better if the highlight
    thickness of the buttons was not set to 0, but to 2.
    That would also make the appearance more consistent
    with that of buttons in other dialogs. Don't you think so ?

     
  • Logged In: YES
    user_id=81393

    ... I think so, too. By now I just didn't care about all the
    hardcoded thicknesses and so on which have already been in
    help.c. I suggest simmply to remove them. (This additionally
    gives the user to change the settings in his .Xdefaults if
    (s)he likes to.) See help_one_window_07-BETA-5-3.diff.

     
  • Eddy De Greef
    Eddy De Greef
    2002-03-18

    Logged In: YES
    user_id=73597

    Sorry to keep nagging, but removing the shadow thickness
    from the form was not such a good idea. It doesn't look
    good with the default settings. But I'll fix that when
    I apply the patch.

    I think that it this addresses most people's concerns,
    so unless there are some objections I'll commit these
    enhancements later this evening.

     
  • Alexander Mai
    Alexander Mai
    2002-03-18

    • labels: --> Program
    • milestone: --> development
    • assigned_to: nobody --> edg
     
  • Eddy De Greef
    Eddy De Greef
    2002-05-06

    • status: open --> closed
     
<< < 1 2 3 (Page 3 of 3)