Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#17 Replace dialog extensions

closed
Eddy De Greef
None
5
2001-04-08
2001-03-23
Eddy De Greef
No

[Patch submitted by Markus Schwarzenberg]

Additional comments concerning the patch

1. I added the Case Sensitive stickyness, I have
tested it quite a little bitte but I'm still not
shure if it really works in all situations as
expected.

Because of when testing this I found the sticky
behavior rather confusing I added an X-Resource:

nedit.stickyCaseSenseBtn

which is on (True) by default. So if anyone (like
me) doesn't like the sticky behavior he can set

nedit.stickyCaseSenseBtn: False

2. The Buttons in the I-search bar are not sticky
yet, shall I add it there, too? Also, I still
didnt't swap them (RegExp first ?)

3. There were some pieces of code (arrays extension,
splitting) which were affected by the change of
regularExp.c/CompileRE. I adapted these parts to
the extended search modes hoping not to have
broken something.

4. A small extension I didn't mention so much before is
the "Beep When Rotate" default setting I added
(Preferences-> Default Settings->Searching). This
acts only if "Wrap Around" is on as follows:

"Beep When Rotate" ON "Verbose" ON
Jumping over EOF/BOF -> only beep (no dialog)
String Not found at all -> Dialog box "String not
Found"

"Beep When Rotate" ON "Verbose" OFF
Jumping over EOF/BOF -> beep
String Not found at all -> two beeps

"Beep When Rotate" OFF "Verbose" ON
As before, dialogs if EOF/BOF is reached or
string isn't found.

"Beep When Rotate" OFF "Verbose" OFF
As before, no messages.

This option should probably be labeled better
(Beep when wrap ??)

5. For the new search modes I had to add new search
method strings. I probably didn't select the best
names, if something needs to be changed just
change the strings in search.h:
#define SEARCH_CASE_SENSE_WORD_STRING "casWord"
and so on.

6. In my dialog I had another replaceAndFindCB
function which was called by the "Replace & Find"
butten - it's now unused (replaceFindCB is used
instead) but for comparision reasons still in the
source (I did it simply calling "replace" and then
"find" which worked in the same way, just the
macro recording showed the two seperate calls of
these functions instead of the one new
"replace_find"). I suppose my function can be put
away.

7. I just tried to apply the new patch again to
the unmodified cvs-version, it fails - don't know
why - 3 times at search.c, so I add search.c
directly.

Discussion

1 2 > >> (Page 1 of 2)
  • Eddy De Greef
    Eddy De Greef
    2001-03-23

     
    Attachments
  • Eddy De Greef
    Eddy De Greef
    2001-03-23

     
    Attachments
  • Eddy De Greef
    Eddy De Greef
    2001-03-23

    Logged In: YES
    user_id=73597

    Just the additional search.c file mentioned in item 7.

     
  • Scott Tringali
    Scott Tringali
    2001-03-25

    Logged In: YES
    user_id=11321

    We're still working out the details of this on the mailing
    list. This overlaps a bit with the "replace in all"
    functionality, but I'd like to keep the two as separate as
    possible. There is a lot of controversy about this dialog!
    :)

     
  • Eddy De Greef
    Eddy De Greef
    2001-03-26

    Logged In: YES
    user_id=73597

    I think there are 3 issues:

    - whole word & case-insensitive regex extensions
    - beep on search wrap
    - replace dialog layout

    This patch only involves the first 2, and I don't
    think that anyone will object against adding this
    functionality, provided that it works properly.

    The main remaining point of discussion is the layout of
    the (bottom 2 rows of the) replace dialog. I intend
    to implement both competing alternatives (scope
    radio buttons or push buttons), such that we can
    all try them out and vote afterwards. Otherwise, this
    discussion will never end ...

     
  • Scott Tringali
    Scott Tringali
    2001-03-26

    Logged In: YES
    user_id=11321

    Sounds good. Let's keep this patch limited to the first two
    and we should be able to move this forward.

     
  • Scott Tringali
    Scott Tringali
    2001-03-27

    • assigned_to: nobody --> edg
     
  • Eddy De Greef
    Eddy De Greef
    2001-03-31

    Reviewed changes + new replace dialog layouts

     
    Attachments
  • Eddy De Greef
    Eddy De Greef
    2001-03-31

    Logged In: YES
    user_id=73597

    The new patch contains the reviewed search extensions
    (only minor changes wrt. to the original patch), but
    also two alternative replace dialog layout propositions.
    The search extensions alter the dialog layout anyhow,
    and it was just too difficult to make two separate patches.
    For more information, refer to the develop mailing list.

     
  • Eddy De Greef
    Eddy De Greef
    2001-04-08

    Logged In: YES
    user_id=73597

    The patches are integrated, so this can be closed.

     
1 2 > >> (Page 1 of 2)