#101 modeless tabbed window

closed
nobody
None
5
2004-02-21
2004-02-09
TK Soh
No

With this patch, there's no more tabbed mode. Here's
the list of changes:

1. the preference 'Open File In New Tab' (better
name?), resource nedit.openInTab: True, decides if
files should be opened in new tabs/windows?

2. File->New is now File->New_Window. Ctrl-N retained.
<Shift> key functionality has been removed.

3. added File->New_Tab with Ctrl-T.

4. option -win has been removed.

5. options -tabbed & -untabbed (both nc & nedit) are
now used to decide whether the files end up in
tabs/windows. Both options apply to all files specified
after the options. If neither present, then
nedit.openInTab is consulted.

Discussion

  • TK Soh
    TK Soh
    2004-02-09

    patch v1.0: against CVS -D 8-Feb-2004

     
    Attachments
  • Tony Balinski
    Tony Balinski
    2004-02-09

    Logged In: YES
    user_id=618141

    Excellent.

    Two small niggles:

    1) File>Open/Open Previous/Open Selected always open a new
    tab, rather than a new window when openInTab is False.

    2) File>New Tab's accelerator (Ctrl+T) was already being
    used for "Replace Find Again"

    I think the Open (anything) menu entries should use the
    openInTab setting too. I don't know what to do about Ctrl+T:
    I would prefer to have it opening a new tab, as you have
    implemented it.

     
  • TK Soh
    TK Soh
    2004-02-10

    Logged In: YES
    user_id=411637

    I need to fix item #1.

    To go along with the 'standard', Ctrl-T is the right choice
    for new-tab. Perhaps we should move the shortcut for
    "Replace Find Again" to something else. Suggestion?

     
  • Igor Kuharchuk
    Igor Kuharchuk
    2004-02-10

    Logged In: YES
    user_id=963183

    Please tell me how can I get tabs with nedit 5.4. I have looked
    around and cannot find a way to make that. Could you please
    give me procedure to build 5.4 with tabs?

     
  • TK Soh
    TK Soh
    2004-02-13

    Logged In: YES
    user_id=411637

    patch v1.1:

    1. fixed a bug where Open/Open Previous/Open Selected always
    open a new
    tab;

    2. changed shortcut for new-tab to Shift-Ctrl-N like in
    Konqueror - until someone comes up with a better idea.

     
  • TK Soh
    TK Soh
    2004-02-13

    patch v1.1: bugfix and new shortcut

     
    Attachments
  • TK Soh
    TK Soh
    2004-02-13

    Logged In: YES
    user_id=411637

    On second thought, I am going to commit the patch in the
    very near future; since it is really a necessity rather than
    an enhancement. So, if anyone spotted something really
    wrong about the patch, stop me please.

     
  • Tony Balinski
    Tony Balinski
    2004-02-20

    Logged In: YES
    user_id=618141

    Can we close this one now the code has been integrated?

     
  • TK Soh
    TK Soh
    2004-02-21

    • status: open --> closed
     
  • TK Soh
    TK Soh
    2004-02-21

    Logged In: YES
    user_id=411637

    Closed. Patch has been committed to CVS.