#87 No titles in some dialog boxes

release
closed-fixed
Program (402)
3
2003-04-08
2001-11-12
Scott Tringali
No

Some modal dialog boxes have no window title:

Open
Save As
Include File
Load Tags
(perhaps more)

All windows should have titles.

Discussion

  • Alexander Mai
    Alexander Mai
    2001-11-13

    Logged In: YES
    user_id=15180

    Agreed.
    Any volunteer on this?

     
  • Thorsten Haude
    Thorsten Haude
    2001-11-23

    Logged In: YES
    user_id=119143

    Fixed some, changing some labels in the process to prevent
    duplicates. Please check whether you like it.

    A lot of dialogs use DialogF(), which does not accept
    titles. DialogF() is a vararg function that accepts char
    pointer for diverse purposes, and I didn't feel like
    changing it right now.

    I'll send the fix to the list.

     
  • Scott Tringali
    Scott Tringali
    2001-11-28

    Logged In: YES
    user_id=11321

    Patch looks good. I had one comment, though. Usually, it's
    standard GUI practice to make the dialog title the same as
    the menu item that invoked it. (This helps users connect
    the two.)

    So, instead of "ctags File", it should "Load Tags File",
    etc.

    Of course, if there's a good reason not to make it the same,
    then it's fine to deviate. But most of them should be the
    same.

     
  • Alexander Mai
    Alexander Mai
    2001-12-24

    Logged In: YES
    user_id=15180

    Patch went in unmodified for now.
    It's easier to modify things in CVS now if
    necessary...
    (perhaps we even have other "non-conforming"
    dialog titles?!)

     
  • Scott Tringali
    Scott Tringali
    2001-12-26

    • assigned_to: nobody --> tringali
     
  • Scott Tringali
    Scott Tringali
    2001-12-26

    Logged In: YES
    user_id=11321

    Assign to me... the patch doesn't really address all the
    windows in the system and needs more work.

     
  • Thorsten Haude
    Thorsten Haude
    2003-04-08

    Logged In: YES
    user_id=119143

    Committed.

     
  • Thorsten Haude
    Thorsten Haude
    2003-04-08

    • assigned_to: tringali --> yooden
    • status: open --> closed-fixed