Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#616 fix possible stack overflow in interpreter

open-fixed
nobody
Program (402)
5
2008-03-09
2008-02-06
Bert Wesarg
No

the check for stack overflow in pushSymVal() should be done before writing to the stack

Discussion

<< < 1 2 3 > >> (Page 2 of 3)
  • Bert Wesarg
    Bert Wesarg
    2008-02-07

    Logged In: YES
    user_id=122956
    Originator: YES

    sorry forget to refresh the actual patch file
    File Added: interpret-macro-cleanup.patch

     
  • Bert Wesarg
    Bert Wesarg
    2008-02-21

    Logged In: YES
    user_id=122956
    Originator: YES

    follow-up patch updated: the StringToNumberMsg now includes a '%s' to print the string that was tried to convert to a number (this was actually found in the Patch Collection)
    File Added: interpret-macro-cleanup.patch

     
  • Scott Tringali
    Scott Tringali
    2008-02-21

    Logged In: YES
    user_id=11321
    Originator: NO

    Good stuff here. I added you as a developer, I hope it's easier to update/commit changes directly than write patches.

     
  • Bert Wesarg
    Bert Wesarg
    2008-03-01

    Logged In: YES
    user_id=122956
    Originator: YES

    Ok, I committed the actual bug fix. for the clean-up of the stack macros (ie the follow-up patch) I like to get an ACK, at least from tony, because he do most inside interpret.c and this will break some of his patches, because of the needed ';' after all stack macros.

    I attached an updated patch.

    File Added: interpret-macro-cleanup.patch

     
  • Thorsten Haude
    Thorsten Haude
    2008-03-09

    • status: open --> closed-fixed
     
  • Thorsten Haude
    Thorsten Haude
    2008-03-09

    Logged In: YES
    user_id=119143
    Originator: NO

    So I assume that this is fixed.

     
  • Bert Wesarg
    Bert Wesarg
    2008-03-09

    Logged In: YES
    user_id=122956
    Originator: YES

    I leaved it open for the ReleaseNotes

    I will handle the cleanup patch outside of this bug report

     
<< < 1 2 3 > >> (Page 2 of 3)