#560 Use updated macros

closed-fixed
None
9
2007-01-04
2006-10-17
Thorsten Haude
No

Discussion

  • Thorsten Haude
    Thorsten Haude
    2006-11-22

    Logged In: YES
    user_id=119143
    Originator: YES

    Please check the attached patch.

     
  • Tony Balinski
    Tony Balinski
    2006-12-13

    Logged In: YES
    user_id=618141
    Originator: NO

    The "Fill Sel. w/Char" macro checks out fine IMO.
    I don't quite know what to look for in the "Complete Word" macro, but it works well, repeated Alt+Ds giving alternative expansions.

    Both macros should have a comment block saying what they do:
    For Fill Sel. w/Char:

    # This macro replaces each character position in
    # the selection with the string typed into the dialog
    # it displays.

    For Complete Word:

    # This macro attempts to complete the current word by
    # finding another word in the same document that has
    # the same prefix; repeated invocations of the macro
    # (by repeated typing of its accelerator, say) cycles
    # through the alternatives found.

    Finally, your patch file contains an update to tags.c that shouldn't be in this file. (No big deal, but...)

    I would recommend making the macro text changes to preferences.c that are in this file.

    Tony

     
  • Thorsten Haude
    Thorsten Haude
    2006-12-13

    Logged In: YES
    user_id=119143
    Originator: YES

    I will put in the comments... soon, probably on the weekend.

    The stuff in tags.c is a simple text replacement, I figured it wouldn't be worth an own patch.<shrug/>

     
  • Thorsten Haude
    Thorsten Haude
    2007-01-04

    • status: open --> open-fixed
     
  • Thorsten Haude
    Thorsten Haude
    2007-01-04

    • status: open-fixed --> closed-fixed