#504 Fix for SF#557032 not working as expected

closed-fixed
None
5
2005-12-17
2005-12-15
Anonymous
No

Fix for SF#557032 not working as expected.

For example,

1) first open a file "a.c" with nedit;

2) if 1) was sucessful, we should be able to see "a.c"
in the "open previous" list. This is currently OK.

3) open another file "b.c".

4) if 3) was successful, we should be able to see "b.c"
in both "open previous" lists, but what I observed is
it only appears in the last one.

Thank you for the fix.

Discussion

  • Thorsten Haude
    Thorsten Haude
    2005-12-15

    • status: open --> open-accepted
     
  • TK Soh
    TK Soh
    2005-12-16

    Logged In: YES
    user_id=411637

    The fix was targeted at the race condition.

    What you saw was that the prev-open menus didn't synch with
    the content of nedit.history. It'd be nice if it's done so,
    but it's going take some non-trivial change.

     
  • Thorsten Haude
    Thorsten Haude
    2005-12-16

    • assigned_to: nobody --> yooden
     
  • Thorsten Haude
    Thorsten Haude
    2005-12-16

    Logged In: YES
    user_id=119143

    I think I have the fix, but I would like to take another
    look (again at the second attempt of fixing the bug). It was
    not difficult based on TK's patch.

     
  • Logged In: NO

    By the way, about your latest fix for SF#464967, it works OK
    but I think it might be better if you add one more line in
    "textDisp.c":

    original (line 1625):
    ----------------------------------------
    TextDRedisplayRange(textD, startDispPos, endDispPos);
    -----------------------------------------

    new:
    -----------------------------------------
    TextDRedisplayRange(textD, startDispPos, endDispPos);
    TextDRedisplayRange(textD, textD->cursorPos-1,
    textD->cursorPos+1);
    -----------------------------------------

    Without the second line, when you move the cursor to the
    right of a "[]" or "()" (no blank between two brackets),
    your will see the left portion of the cursor will not be
    displayed.

    What I mean is, if a normal cursor is like the following:

    ---
    |
    |
    |
    ---

    in the case I described, you'll see it is like

    --
    |
    |
    |
    --

    Thank you for all the fixes.

     
  • TK Soh
    TK Soh
    2005-12-16

    Logged In: YES
    user_id=411637

    > By the way, about your latest fix for SF#464967,

    Please, PLEASE, do not post messages on irrelavent topics.
    Go to SF#464967 to add your follow-up.

     
  • Thorsten Haude
    Thorsten Haude
    2005-12-17

    Logged In: YES
    user_id=119143

    I agree with TK, please repost your suggestions at the Bug
    you mention.

     
  • Thorsten Haude
    Thorsten Haude
    2005-12-17

    • status: open-accepted --> closed-fixed