#374 Help font inconsistent with window size

development
closed-fixed
Eddy De Greef
Program (402)
5
2004-07-08
2004-06-30
Yury Burkatovsky
No

Hello,

I paid attention that the help window in the CVS dev
version became smaller as compared to the version 5.4.

As a result, the sections that contain indented text
look ugly due to wraparound, even with the default
helpFont setting to "helvetica medium 12 points". To
fix this outlook, I have to increase the help window
width so that the wraparound would disappear.

Please see attached the example screenshot of the
"Modifier Keys (in general)" section in Help->Basic
Operation->Keyboard Shortcuts.

I believe the average user would expect the help
window size to match the font size. This applies in
particular to visually impared users who have to
increase the default font size so that to eliminate
their eye strain.

Discussion

  • screenshot

     
    Attachments
  • Eddy De Greef
    Eddy De Greef
    2004-06-30

    Logged In: YES
    user_id=73597

    This was reported before (see
    http://www.nedit.org/pipermail/develop/2004-May/008650.html\).
    I did a binary search on CVS and narrowed it down to the
    fontlist-related changes that happened in nedit.c around
    April 19.
    I don't understand how those changes can affect the width of
    the help window (we still use the same font).
    The width calculation for the help window is bogus anyhow,
    so as a shortcut, I've increased the initial help window
    size from 65 to 75, which seems to come close to the old
    size in reality, at least for the default fonts.

     
  • Eddy De Greef
    Eddy De Greef
    2004-06-30

    • assigned_to: nobody --> edg
    • status: open --> open-fixed
     
  • Scott Tringali
    Scott Tringali
    2004-07-01

    Logged In: YES
    user_id=11321

    I think it may have been a bug in the old font setup, I
    think the old window size was calculated against the wrong
    font, and then changed afterwards.

    Something about changing the font between initialization and
    showing it, I suspect.

     
  • Logged In: NO

    The help windows use primarily variable-width font. I wonder
    how the calculation based on column size could actually be
    done correctly.

    -TK

     
  • Scott Tringali
    Scott Tringali
    2004-07-02

    Logged In: YES
    user_id=11321

    I'd have to look it up, but it probably uses the average
    width or something like that.

     
  • Eddy De Greef
    Eddy De Greef
    2004-07-08

    Logged In: YES
    user_id=73597

    I think I understand what is happening now.
    We used to have a resource "*helpText.font" and that font
    was used to calculate the initial help window size.
    Now that resource is removed and it was assumed that the
    Motif "*textFontList" catch-all resource also affects the
    help text widget. However, that widget is an instance of our
    custom textWidgetClass, which doesn't know about the
    textFontList resource. So the initial size calculation is
    now based on some default font supplied by Motif, which
    differs in size from our old font.

    Anyway, whichever of these fonts we use for the calculation,
    it quite meaningless, because we mix different fonts in the
    help text and there is little or no relation to the font
    used for the size calculation.

    I've now changed the help text initialization such that it
    explicitly uses the fixed font used in the help widget to
    perform the size calculation. So, the size now depends on
    nedit*fixedHelpFont, which gives exactly the same results as
    before.

     
  • Eddy De Greef
    Eddy De Greef
    2004-07-08

    • status: open-fixed --> closed-fixed