> Here's what i got from one of our users. He pretends he cleaned up ndisasm
> main loop and some other files. I haven't got time to look at this, please
I have looked at them.
The ndisasm.c changes merely re-order the components of the main loop, but
don't really change them, except for a conditional operator that is being
used instead of one of the if conditions. So as of writing this I don't see
a compelling reason to apply those changes. The originator should consider
supplying more details about the idea behind them, reason for them, etc.
The disasm.c changes consist of two parts. First, they change the order in
which the codes (that make up an instruction template) are processed. And
second, they change the way prefixes are processed. One of the comments is
mentioning performance as the driving factor for these changes -- however,
the originator didn't supply compelling (actually: any) performance data.
So again, I don't see a compelling reason to apply -- more info is needed.
Do you Yahoo!?
Yahoo! Mail SpamGuard - Read only the mail you want.