Re: [Nasm-devel] [patch v2 2/2] insns.dat - introcuce base XOP (SSE5) AMD instructions

[anonymous c. <nas...@us...>]

Had the new entries been sorted by opcode, then the following
mistakes would have been more obvious:

> +PMACSSWW       xmmreg,xmmreg,xmmrm,xmmreg      [rvms:  xop.m8.w0.nds.l0.p0 85 /r /is4]         AMD,SSE5,SO
> +PMACSSDQL      xmmreg,xmmreg,xmmrm,xmmreg      [rvms:  xop.m8.w0.nds.l0.p0 87 /r /is4]         AMD,SSE5,SO

missing leading V

> +VPMACSDQH      xmmreg,xmmreg,xmmrm,xmmreg      [rvms:  xop.m8.w0.nds.l0.p0 9f /r /is4]         AMD,SSE5,SO
> +VPMACSDQH      xmmreg,xmmreg,xmmrm,xmmreg      [rvms:  xop.m8.w0.nds.l0.p0 9f /r /is4]         AMD,SSE5,SO

missign VPMACSDQL (97), but duplicate VPMACSDQH (9F)

> +PMADCSWD       xmmreg,xmmreg,xmmrm,xmmreg      [rvms:  xop.m8.w0.nds.l0.p0 b6 /r /is4]         AMD,SSE5,SO

missing leading V

> +VPROTB         xmmreg,xmmreg,imm               [rmi:   xop.m8.w0.l0.p0 c0 /r ib]               AMD,SSE5

should be xmmreg,xmmrm,imm like VPROT[WDQ]

> +VPCOMB         xmmreg,xmmreg,xmmrm,imm         [rvmi:  xop.m8.w0.nds.l0.p0 ed /r ib]   AMD,SSE5,SO

should be VPCOMUB

> +VPHADDWD       ymmreg,ymmrm                    [rm:    xop.m9.w0.l0.p0 c6 /r]          AMD,SSE5,SO
> +VPHADDUBD      ymmreg,ymmrm                    [rm:    xop.m9.w0.l0.p0 d2 /r]          AMD,SSE5,SO

should be xmmreg,xmmrm like all other VPHADDs

I only performed a visual inspection -- I did not try actual testcases.