#18 CodeStats Enhancements to Support Multiple LineCounters

closed-fixed
Gert Driesen
None
5
2005-04-16
2005-01-24
justinj
No

The codestats module did not quite fit what I needed it
to do which was to allow me to get a linecount for
multiple kinds of file types, label them and append the
output to a file.

So I made the modifications needed to enable this
functionality. I have included a patch file for the
CodeStats.cs file located in the Tasks folder as well as 2
new files for the CodeStatsType and
CodeStatsTypeCollection.

Please let me know what I need to do to get this
integrated into NAntContrib.

Changes:

* Made it so you can append to the output file
* Made it so that you can choose to only show the
summary for the whole fileset instead of individual files.
* Added buildname attribute
* Fixed bug with the file summary output including the
directory and filename twice
* Re-formatted xml document output so that for each
run, it creates a code summary node, then a linecount
node for each fileset and a file summaries/summary node
for each individual file.

Thx

Discussion

  • justinj
    justinj
    2005-01-24

    sample output

     
    Attachments
  • justinj
    justinj
    2005-01-24

    sample build file

     
    Attachments
  • Jason S Morris
    Jason S Morris
    2005-01-25

    Logged In: YES
    user_id=405288

    I would very much like to see this patch commited before the
    nant .85 release. I could use this enhancement immediately!

     
  • Gert Driesen
    Gert Driesen
    2005-01-25

    Logged In: YES
    user_id=707851

    I'll try to review it asap, but don't hesitate to remind me if
    necessary ;-)

     
  • justinj
    justinj
    2005-01-31

    Logged In: YES
    user_id=1176927

    any word on getting this committed?

     
  • Gert Driesen
    Gert Driesen
    2005-01-31

    Logged In: YES
    user_id=707851

    Just had a quick look, and I wonder if it would be better to
    have the CodeStatsType derive from FileSet.

    I won't have much time until friday, so ...

     
  • justinj
    justinj
    2005-02-04

    Logged In: YES
    user_id=1176927

    I am not sure on this one. I am not an expert on the inner
    working of nant. I just followed some examples that I had of
    other custom task that I had.

    I can make an change that you feel are needed for this to
    get committed into cvs.

     
  • justinj
    justinj
    2005-02-14

    Logged In: YES
    user_id=1176927

    i changed the CodeStatsType to inherit from FileSet.
    Please let me know what else I need to do to ensure that this
    makes it into the final nantcontrib release.

     
  • justinj
    justinj
    2005-02-14

    Logged In: YES
    user_id=1176927

    i changed the CodeStatsType to inherit from FileSet.
    Please let me know what else I need to do to ensure that this
    makes it into the final nantcontrib release.

     
  • justinj
    justinj
    2005-02-14

    Updated Files

     
    Attachments
  • justinj
    justinj
    2005-03-08

    Logged In: YES
    user_id=1176927

    Is it going to be possible to get this patch committed?

     
  • Gert Driesen
    Gert Driesen
    2005-04-15

    Logged In: YES
    user_id=707851

    This will be committed in time for NAntContrib 0.85 RC3.

     
  • Gert Driesen
    Gert Driesen
    2005-04-16

    Logged In: YES
    user_id=707851

    This is now in cvs.

    Thanks for the contribution ! (sorry that it took so long for this
    to get committed)

     
  • Gert Driesen
    Gert Driesen
    2005-04-16

    • assigned_to: nobody --> drieseng
    • status: open --> closed-fixed