Re: [nant-dev] Contributing

[Matthew M. <ma...@ac...>]

Awesome!  Thanks for the fixes.  Please see my notes inline.  As John
mentioned, use diff -u to provide a patch.  We can get this stuff
checked into CVS.

On Wed, 2003-07-30 at 16:08, Tom Cabanski wrote:
> I=E2=80=99ve cleaned up a variety of little bugs in the solution task as
> follows:
>=20
> =20
>=20
> Leaks temp files under some circumstances.   Fixed.

This was fixed in the latest from CVS.  I can check your patch to see if
there were any places that I had missed.

> Define settings are not read from project file (e.g. TRACE;DEBUG).=20
> Fixed.

Cool.

> Resource compiles blow up under some circumstances because of changes
> to the ResGen task.  Fixed.

I think some changes in the HEAD release had broken this part of the
solution task.  Thanks...

> I=E2=80=99ve also added a couple new features because the WebDAV thing wa=
s
> such a pain.  The Solution task now includes the following attributes:
>=20
> =20
>=20
> webmap(optional):

Would it be possible to provide webmap elements, rather than a file?=20
This would be more NAnt-style if you could specify:

<solution>
  <webmap url=3D"http://...." path=3D"..."/>
</solution>

Ian would likely know the best way to go about providing these
elements. =20

> The name of a file that maps web project URLs to their physical file
> path.  Each line in the file takes the form <web project
> URL><space><Physical path to project>.  If this attribute is provided,
> WebDAV is not used for the mapped project(s).
>=20
> =20
>=20
> Outputdir(optional):
>=20
> The name of the path where output DLLs and EXEs will be placed.  This
> overrides settings from the project file.

Awesome...  Does it still work with the "up-to-date" check?  I think it
should, but it might be something to try out.  At some point I'll have
to fix the task so that it doesn't copy *every* file from the reference
.dll's directory (with the exception of project references, I guess).=20
I've noticed that a lot of junk DLLs end up getting copied as part of a
build process.
=20
>=20
> excludeprojects  (fileset) (optional):
>=20
> Projects that will not be built.  I added this because when building
> from a solution it does not honor the Build|Configuration Manager
> settings for the configuration.  I checked the .csproj and .sln files
> for these settings but they aren=E2=80=99t there.  I guess they are burie=
d in
> the .suo or .user files.  Anyway, my project has a bunc of sample
> applications that we only want to build as part of the release and
> this was a handy way to set it all up.

Good addition...

The build configurations are stored in the cryptic .sln file.  I hadn't
had a chance to parse those out (mostly because we found that VS.NET was
corrupting them more often than not :)). =20

> =20
>=20
> My changes are restricted to the NAnt.VSNet project.
>=20
> =20
>=20
> How do I go about contributing all of this?
>=20
> =20
>=20
> Thanks
>=20
> -------------------------------------
>=20
> Tom Cabanski, President
>=20
> Objective Advantage, Inc.
>=20
> http://www.oai.cc
>=20
> Phone: +1-281-348-2517x15
>=20
> =20
>=20
> =20
--=20
Matthew Mastracci <ma...@ac...>