Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#323 HTTP compliance in check_http

closed-works-for-me
nobody
None
5
2009-06-22
2009-06-22
Henrik Nilsson
No

check_http v1.4.13.138.g9eab.dirty (nagios-plugins 1.4.13)
Example plugin commandline: plugins/check_http -I http1-0server.com
Tested on: Fedora 10, i686 with compiler gcc (GCC) 4.3.2 20081105 (Red Hat
4.3.2-7)
Originally the plugins sends the "Connection: close" in all cases, while only HTTP/1.1 supports it (HTTP/1.0 has this behaviour by default, not supporting keep-alive), the patch makes it use "Connection: close" only when using HTTP/1.1

Discussion

  • Henrik Nilsson
    Henrik Nilsson
    2009-06-22

    Patch to fix HTTP/1.0 compliance in check_http

     
    Attachments
  • Holger Weiß
    Holger Weiß
    2009-06-22

    We heard reports of server configurations which only close the connection after sending the response if "Connection: close" was specified even in the case of HTTP/1.0 requests. Therefore, we didn't limit the use of this header line to HTTP/1.1 requests.

    Have you seen any HTTP/1.0 server which complains about the header? If so, that would be a server bug, as the HTTP/1.0 standard clearly states that "Unrecognized header fields should be ignored by the recipient" (RFC 1945, 7.1).

    That said, I wonder whether anyone actually checks a server which cannot handle HTTP/1.1 requests these days. Maybe we should drop HTTP/1.0 support entirely some day.

     
  • Holger Weiß
    Holger Weiß
    2009-06-22

    • status: open --> pending-works-for-me
     
  • Henrik Nilsson
    Henrik Nilsson
    2009-06-22

    We have received reports that a proxy bails out when receiving "Connection: close" for HTTP/1.0, however after reading the RFC I agree it is the error of the proxy.

     
  • Henrik Nilsson
    Henrik Nilsson
    2009-06-22

    • status: pending-works-for-me --> open-works-for-me
     
  • Henrik Nilsson
    Henrik Nilsson
    2009-06-22

    • status: open-works-for-me --> closed-works-for-me