#827 mumble shows large text messages as plain html

Current_GIT
open
nobody
Mumble (544)
5
2012-10-30
2011-09-13
No

text messages appears unformated in chat window if message is bigger than your screen height if the client would display it in a window.
This is not good behaviour for me.
I would like to see all messages even If they larger then my screen. Evcn images.

Related

Bugs: #766

Discussion

  • screenshot of this bug

     
    Attachments
  • fwaggle
    fwaggle
    2011-10-01

    Duplicate of #3196994?

     
  • Duplicate of #3196994?
    Yes. Seems like.

    Solution is very simple. I removed checking of screen size in Log.cpp.
    I'll put my dirty patch to bug #3196994

     
  • dirty patch to remove this problem.

     
    Attachments
  • Ups. I can't post things to not mine bugs. So patch is here.

     
  • This could be fixed by adding a new parameter to Log::validHtml which controls the screen size check and is set to false when it's used for log messages (because the size check is still useful for the comment tooltip).

     
  • fwaggle
    fwaggle
    2011-10-02

    pcgod: Something like this?

    https://github.com/fwaggle/mumble/commit/ef68e13c6c9c87511608886f6fa2c2e67a36cf06

    It strikes me that this behavior should be a toggle, probably even defaulting to on. I probably don't want to see really really long messages. Come to think of it, is there any way to make the behavior to emit the HTML or the "text is too long" message, then allow you to click on it and display the message anyway?