Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1004 Mumble crashing when loading non-included DLLs

1.2.4
invalid
nobody
1.2.4
3
2013-12-16
2013-06-25
Nick Ippoliti
No

Hello, I am working on a plugin, and something strange seems to be happening. It seems that mumble is crashing when it does not recognize the DLL name (ie. if I call my plugin cs.dll, mumble won't crash, but calling it unknown.dll causes mumble to crash). I'm using Windows 8

Steps to reproduce
1) Compile positional audio plugin (can post my source code if necessary)
2) Place in C:\Program Files (x86)\Mumble\plugins named unknown.dll
3) Open Mumble
4) Open Settings, instant crash
5) Go back into plugins folder
6) Rename unknown.dll to cs.dll (A default plugin, which I have moved out of the plugins folder)
7) Open Mumble
8) Open Settings, no crash

Seems weird to me. Using MumblePAHelper shows that my plugin is reporting the correct values, correct description, etc. even when not using an included plugin name, leading me to believe that this is something wrong with mumble itself. Thanks in advanced for your consideration!

1 Attachments

Discussion

  • Nick Ippoliti
    Nick Ippoliti
    2013-06-26

    Also, it may be worth it to note that the name change/removal of cs.dll doesn't actually seem to remove it, as it is still listed under the plugin list. Nor does changing my plugin name to cs.dll cause it to show up under the plugin list. Mumble also seems to function fine aside from opening the settings.

    EDIT: The plugin also functions, it's only the settings screen that causes any crashing.

     
    Last edit: Nick Ippoliti 2013-06-26
  • Micah
    Micah
    2013-07-01

    A friend and I are experiencing the same problem. I believe that the plug-in is not loading in the reporter's description but rather mumble is re-downloading the original plug-in and overwriting the user's plugin (when the name is set to one of the stock plugin names).

    I am also on Windows 8 running mumble 1.2.4. A friend experiences the same crash, I am uncertain what his mumble version / OS version are.

     
  • Mikkel Krautz
    Mikkel Krautz
    2013-07-01

    Mumble's Windows builds are built with MSVC10 (Visual Studio 2010), with the Windows 7 SDK. To ensure 100% C++ ABI compatibility, you should use the same compiler - otherwise you will most likely get crashes like is described here. :-)

    Can you confirm that using MSVC10 fixes the issue for you? Also, as Micah points out, if you call your plugin 'cs.dll', Mumble is probably using its own 'cs.dll' (either by re-downloading, or by using the one distributed with hte installer) rather than yours.

     
  • Mikkel Krautz
    Mikkel Krautz
    2013-07-01

    • status: open --> awaiting-reply
     
  • Nick Ippoliti
    Nick Ippoliti
    2013-07-01

    I'm using MSVC10 as my IDE and using the most recent Windows SDK (http://msdn.microsoft.com/en-us/library/windows/desktop/hh852363.aspx). I'll try to compile it with the Windows 7 SDK when I get home to check. Thanks for replying!

     
  • Nick Ippoliti
    Nick Ippoliti
    2013-07-01

    Also, yes I've come to realize that my plugin is being replaced by Mumble's own when using a stock DLL name

     
  • Nick Ippoliti
    Nick Ippoliti
    2013-07-01

    Alright, sorry for the triple post, but I just compiled it against the Windows 7 SDK and still I am getting crashes.

     
  • Kissaki
    Kissaki
    2013-11-05

    As you indicated you removed cd.dll but the plugin was still listed I guess the issue is this:

    On installation Mumble puts the installers plugin DLLs into the installation folders plugins sub directory.
    However, on plugin updates the new DLLs will be put into the user writable %APPDATA%\Mumble\Plugins folder.
    So I guess you removed and replaced the cs.dll in your installation directory, but actually saw no crashes because the cs.dll that was used was still the original in the appdata folder.
    Is this conclusion correct?

    As we moved our bug tracker to github, please refer to the new ticket for answering.
    https://github.com/mumble-voip/mumble/issues/1004

     
  • Kissaki
    Kissaki
    2013-12-16

    • status: awaiting-reply --> invalid