Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2 Check return codes everywhere

open-later
nobody
None
1
2007-07-03
2007-02-22
Markus Elfring
No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "fprintf" in functions like "generateMessage" and "mysslerr"?
http://mstone.svn.sourceforge.net/viewvc/mstone/trunk/mstone/src/generate.c?revision=7&view=markup
http://mstone.svn.sourceforge.net/viewvc/mstone/trunk/mstone/src/socket.c?revision=7&view=markup

Discussion

  • Dan Christian
    Dan Christian
    2007-07-03

    • status: open --> open-works-for-me
     
  • Dan Christian
    Dan Christian
    2007-07-03

    Logged In: YES
    user_id=865423
    Originator: NO

    This isn't a bug report, it's a question... It's true that return codes aren't used consistently or everywhere. It works fine for me in practice.

    I'm not going to make arbitrary clean up until I am actively working with a section of code (so it can be fully tested).

    If a specific problem is showing up, please file that as a bug.

     
  • Dan Christian
    Dan Christian
    2007-07-03

    • status: open-works-for-me --> closed-works-for-me
     
  • Markus Elfring
    Markus Elfring
    2007-07-03

    Logged In: YES
    user_id=572001
    Originator: YES

    I suggest to avoid unchecked function calls.
    Would you like to detect every error situation as early as possible?

     
  • Markus Elfring
    Markus Elfring
    2007-07-03

    • status: closed-works-for-me --> open-later
     
  • Dan Christian
    Dan Christian
    2007-07-03

    • priority: 5 --> 1
     
  • Dan Christian
    Dan Christian
    2007-07-03

    Logged In: YES
    user_id=865423
    Originator: NO

    What errors have you encountered?
    I need a way to reproduce the problem.

     
  • Markus Elfring
    Markus Elfring
    2007-07-03

    Logged In: YES
    user_id=572001
    Originator: YES

    Do you care for failed output and log messages?