Thread: [Mplayerplug-in-devel] bug in Makefile.in. patch attached.
Brought to you by:
kdekorte
From: Greg H. <gr...@ho...> - 2005-07-14 01:24:25
Attachments:
mplayerplug-in-patch.tar.gz
|
can't believe it took me 3 hours to spot this... your Makefile.in is no good. It will always, and consistently, 100% of the time, build an incorrect set of mplayerplug-in*.so's reason 1: the mplayerplug-in*.so's have an incorrect OBJ reference reason 2: the Makefile uses the same source file to generate the 4 differnt files, but used -c *WITHOUT* a respective '-o filename', hence there was only ever one plugin-setup.o generated, which was then used for all .so's (until reason was fixed, and then you needed to generate the respective output files) :) patch and/or fixed Makefile.in attached. best rgds, -Greg +---------------------------------------------------------------------+ Please also check the log file at "/dev/null" for additional information. (from /var/log/Xorg.setup.log) | Greg Hosler gr...@ho... | +---------------------------------------------------------------------+ |
From: Kevin D. <kde...@ya...> - 2005-07-14 02:11:23
|
On Wednesday 13 July 2005 07:25 pm, Greg Hosler wrote: > can't believe it took me 3 hours to spot this... > > your Makefile.in is no good. It will always, and consistently, 100% of the > time, build an incorrect set of mplayerplug-in*.so's > > reason 1: the mplayerplug-in*.so's have an incorrect OBJ reference > > reason 2: the Makefile uses the same source file to generate the 4 differ= nt > files, but used -c *WITHOUT* a respective '-o filename', hence > there was only ever one plugin-setup.o generated, which was then > used for all .so's (until reason was fixed, and then you needed to genera= te > the respective output files) > > :) > > patch and/or fixed Makefile.in attached. > > best rgds, > > -Greg Greg, Accepted, I had already found/fixed this, but I like your method better. I= =20 fixed up make clean as well and a couple of other little things. Kevin |