#167 [fixed in 2009-Jan build] Doesn't work anymore - D3D9.DLL

svn
closed-out-of-date
MPlayer (86)
5
2013-02-20
2008-12-26
dos386
No

Hi

thanks for providing those executables.

Regrettably MPLAYER recently stopped working for me :-(

Reason is unconditional linking to "D3D9.DLL" and "Direct3DCreate9" - please make it conditional again - use LoadLibrary + GetProcAddress , if not available use high compatibility "GDI" stuff (or what it is) and used to work for me.

Discussion

  • the change is in vo_direct3d code, I see only that import, to make this dynamic I need to make a patch that will never be accepted by upstream authors, which os misses d3d9.dll?

     
    • labels: 1017973 --> MPlayer
    • status: open --> open-accepted
     
    • milestone: --> Next_Release
    • status: open-accepted --> open
     
  • I've made a little patch, it works for me, I'll include it in next builds

     
  • dos386
    dos386
    2008-12-29

    Huh ? Bug closed ? deleted ? moved only :-)

    > is in vo_direct3d code, I see only that import

    YES, but the only 1 import requires the full messy DLL to be present and initialize (and it crashes for me even then there in ...).

    With older builds I get "<FATAL ERROR>failed geting proc address: DirectDrawCreateEx" but there is no fatal error: it finds something else and works :-) So that's what I consider a good design :-)

    > I've made a little patch, it works for me, I'll include it in next builds

    Thanks. I'll test.

     
  • please try latest build

     
  • dos386
    dos386
    2009-01-15

    > please try latest build

    > can't dynamically load d3d9.dll

    Thanks :-) It's indeed fixed and works again ... no d3d9.dll needed anymore (except someone __REALLY__ asks for it).

    Ready for closing. Please try to keep the compatibility as high as possible in future (still 418 unconditional imports, heh ...). Any ideas when we can expect 1.0RC3 or 1.0 final (>1 years since RC2 with much devel but no releases) ? BTW, there are some other (old, unrelated) bugs, going to open artifacts :-|

     
  • dos386
    dos386
    2009-01-15

    • summary: Doesn't work anymore - D3D9.DLL --> [fixed in 2009-Jan build] Doesn't work anymore - D3D9.DLL
     
  • uh?

     
  • Ticket moved from /p/mplayer-win32/feature-requests/27/

     
    • status: open --> closed-out-of-date
    • milestone: Next_Release --> svn