#13 crossapi.cpp fails to compile on linux

closed
nobody
None
5
2009-06-25
2008-11-06
FeRD
No

crossapi.cpp calls open() in 2-argument mode in a couple of places where O_CREAT is (or could be) present, which is illegal and causes a compile-time error under g++ 4.3.0 (Fedora 9).

The attached patch changes those calls to the 3-argument form, arbitrarily using S_IRUSR|S_IWUSR as the mode for created files. (In one of the two instances, the file is a copy destination file and will be fchmod()'d to the mode of the source file anyway.)

Discussion

  • FeRD
    FeRD
    2008-11-06

    patches crossapi.cpp to compile under linux

     
    • status: open --> closed
     
  • fixed in CVS, thanks for a patch

     
  • FeRD
    FeRD
    2009-09-17

    I guess the fix didn't make it into the 0.1.8 release? Building from mp3val-0.1.8-src.tar.gz, I found the patch was still required.