#10 Gentoo QA Notice: "poor programming practices"

closed-fixed
Konstanty
None
5
2009-05-05
2009-02-05
Mr. Anderson
No

When installing ModPlug for XMMS on Gentoo (amd64), portage complains about some compiler warnings (gcc 4.3.3):

QA Notice: Package has poor programming practices which may compile fine but exhibit random runtime failures.
load_ptm.cpp:121: warning: dereferencing type-punned pointer will break strict-aliasing rules

Please do not file a Gentoo bug and instead report the above QA issues directly to the upstream developers of this software.

Discussion

  • Mr. Anderson
    Mr. Anderson
    2009-02-05

    Sorry, I meant libmodplug (0.8.4), not ModPlug for XMMS.

     
  • Konstanty
    Konstanty
    2009-04-07

    • assigned_to: nobody --> metaplasma
    • status: open --> open-accepted
     
  • Konstanty
    Konstanty
    2009-04-07

    In the latest CVS the following patch has been applied for this issue:
    + samplepos = (bswapLE16(psmp->fileofs[0]) << 16) +
    + bswapLE16(psmp->fileofs[1]);
    - samplepos = bswapLE32(*(LPDWORD)(&psmp->fileofs));

     
  • Konstanty
    Konstanty
    2009-04-14

    A more robust patch was added in 0.8.5 (soon to be released)

     
  • Konstanty
    Konstanty
    2009-04-20

    • status: open-accepted --> pending-fixed
     
    • status: pending-fixed --> closed-fixed
     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).