#1 Kernel 2.6.18 uses usb/input.h too

closed
nobody
None
5
2007-04-17
2007-04-08
Anonymous
No

Both lirc_mod_mce.c and mod_mce.c have tests within them to check the version of the kernel being used and based on the version to then either #include linux/usb/input.h (if >= 2.6.19) or #include linux/usb_input.h (if < 2.6.19).

However usb_input.h changed to usb/input.h with 2.6.18 so the check is incorrect.

The correct check should be

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,18)
#include <linux/usb/input.h>
#else
#include <linux/usb_input.h>
#endif

I attach two patch files, one for each C source file.

HTH

Simon

Discussion

  • lirc_mod_mce.patch to fix usb/input.h vs usb_input.h

     
    Attachments
  • Simon Flood
    Simon Flood
    2007-04-08

    Logged In: YES
    user_id=1764308
    Originator: NO

    Perhaps this bug can be attributed to me (simonflood) as I seem to have managed to submit it anonymously which means I can't change it!

    Simon

     
  • Florian Demski
    Florian Demski
    2007-04-17

    Logged In: YES
    user_id=1549018
    Originator: NO

    Uploaded a new version.

     
  • Florian Demski
    Florian Demski
    2007-04-17

    • status: open --> closed