Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#65 unknown colour setting interpreted as black

closed-fixed
nobody
None
8
2012-06-01
2012-05-22
Thomas Wolff
No

mlterm now implements the OSC sequences for colour setting partially,
e.g. ^[]11;yellow^G to set the text background.
However, if the given colour specification is not known, it falls back to black.
This is likely to render text display as black on black :(
e.g. if one tries the colour query sequence ^[]11;?^G which is defined by xterm but not implemented by mlterm

Discussion

  • Thomas Wolff
    Thomas Wolff
    2012-05-23

    I'd like to add that I consider the priority of this problem high since - as I described - it creates the risk to render text invisible.

     
  • Thomas Wolff
    Thomas Wolff
    2012-05-23

    • priority: 5 --> 8
     
  • Araki Ken
    Araki Ken
    2012-05-23

    • status: open --> open-fixed
     
  • Araki Ken
    Araki Ken
    2012-05-23

    Thanks for your report. This is a serious problem indeed.
    Please test an attached patch (quick hack), which ignores "?" to query color spec and which falls back to white for unknown foreground color.

     
  • Thomas Wolff
    Thomas Wolff
    2012-05-24

    The patch is fine as far as my application (editor mined) is concerned.

    However, for any unknown colour specification I would strongly suggest to simply ignore it (like for "?" now) rather than use any fallback. Right now, the fallback for "unknown foreground, unknown background" is white on white - but even if it were white on black or black on white, either choice would be quite arbitrary, and likewise bad for people only (mis)configuring one of them and running their terminal in reverse style (dark on light).

     
  • Araki Ken
    Araki Ken
    2012-05-26

    > I would strongly suggest to simply ignore it (like for "?" now)
    > rather than use any fallback.

    Yes, I think so. The patch I attached is a quick hack.
    I'll fix it before 3.1.3 release.

     
  • Araki Ken
    Araki Ken
    2012-06-01

    • status: open-fixed --> closed-fixed