#23 doallow() should check more than one email address in a line

closed-accepted
Colin Tuckley
None
5
2007-07-20
2004-01-15
Trek Star
No

doallow() should check if all the addresses in the line
are allowed.
doblock() comment about logandreset is wrong.
This patch adds the code to check all the addresses in
the line.

Discussion

  • Trek Star
    Trek Star
    2004-01-15

    doallow() check all the addresses patch

     
  • Logged In: YES
    user_id=1525

    Plese do not tokenize the addresses yourself. Simply splitting on
    commas is bound to fail in a number of cases.

    Look at how smtp_send() in mail.c builds the rcpt buffer and then
    works it off one by one. It does so by calling rfc822_addr() which
    knows quite a bit about how email addresses may look like.

    Also please patch against the current development version.

    Please submit a new patch (also to the mailinglist) when/if you
    have fixed the issues.

     
    • status: open --> open-rejected
     
  • Colin Tuckley
    Colin Tuckley
    2006-07-02

    • assigned_to: nobody --> colintu
     
  • Colin Tuckley
    Colin Tuckley
    2006-07-02

    Logged In: YES
    user_id=618735

    I'm working on a patch for this along the lines weasel suggested

     
  • Colin Tuckley
    Colin Tuckley
    2007-07-05

    • status: open-rejected --> pending-accepted
     
  • Colin Tuckley
    Colin Tuckley
    2007-07-05

    Logged In: YES
    user_id=618735
    Originator: NO

    This is fixed in svn (and has been for some time) it will be incorporated into v3.1

     
    • status: pending-accepted --> closed-accepted
     
  • Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).