Re: [Mixmaster-devel] [ mixmaster-Patches-590492 ] misc fixes for mixmaster-20020802 CVS

[Peter P. <pe...@pa...>]

On Sat, 03 Aug 2002, no...@so... wrote:

> Patches item #590492, was opened at 2002-08-03 13:49
> You can respond by visiting:=20
>=20
> Submitted By: Sami Farin (safari)
>=20
> Initial Comment:
>  Included correct header files.
> =20
>  Src/main.c had incorrect param to buf_appendf.
> =20
>  Added buf_write_sync() (used by Src/rem.c:mix_pool()).
>  Should a mixmaster machine crash, pool file can contain
>  any random data after reboot/journal recovery (at least
>  when using reiserfs).
> =20
>  Maybe not relevant, but strrchr should be used instead of
>  strchr when looking for domain part.
> =20
>  Src/pgpdata.c:pgp_elgdecrypt() passes uninitialized values
>  to BN_free if BN_CTX_new fails.
> =20
>  Src/pgpdata.c:pgp_elgencrypt() passes uninitialized value
>  to BN_free if the third mpi_get(key, i) fails.
> =20
>  Src/random.c does not check return value of read().
> =20
>  Src/rndseed.c does not check return value of read().

Thanks for your contribution. Could you submit different fixes in
different patches and not one big patch in the future please.

					yours,
					peter