From: Lieven H. <li...@li...> - 2015-06-02 19:54:37
|
Hey Tom, The pull request you sent in 2013 apparently indeed did not make it to the main branch because the pull request you created was against the stable branch and we can only accept pull requests against the master branch. See the comments on the pull request here: https://github.com/hollie/misterhouse/pull/250 The pull request for the new file: can you please send me the link to it, because I don’t see it in the list of open pull requests: https://github.com/hollie/misterhouse/pulls? The process on how to create a pull request is documented here: https://github.com/hollie/misterhouse/wiki/Contributing#creating-a-pull-request-for-new-contributors I will merge your pull request into the master branch if you send it in. Best regards, Lieven. > Op 12-mei-2015, om 22:47 heeft Tom <tom...@gm...> het volgende geschreven: > > A couple of years ago I made some updates to xbmc_notification.pl > > The changes included the following: > --allow multiple XBMC clients as targets (instead of a single instance) > --configurable timeout of the popup > --an image to be display in the XBMC popup > > The updated code also included more information on it's usage.. ie: > mh.private.ini entries > > XBMC was updated to KODI in late 2014 and I've updated the references > to reflect this new name on my local machine. > > I noticed the main branch still had the old file so I guess I didn't > get it checked in correctly. > I created a pull request for the new file kodi_notification.pl > > Can you review the changes and if there are no issues, merge them to > the main repo? > > > thanks, > tom > > On Sat, Aug 24, 2013 at 5:02 AM, Lieven Hollevoet <li...@li...> wrote: >> Hey Tom, >> >> looks fine to me. Are there other users of XMBC who can verify? >> >> The pull request of Tom is here: https://github.com/hollie/misterhouse/pull/250/files#diff-0 >> >> Kind regards, >> Lieven. >> >> >> Op 23-aug.-2013, om 20:10 heeft Tom <tom...@gm...> het volgende geschreven: >> >>> I created the pull request.. let me know if I did this correctly. >>> thanks, >>> tom >>> >>> On Fri, Aug 23, 2013 at 2:59 AM, Lieven Hollevoet <li...@li...> wrote: >>>> Hey Tom, >>>> >>>> Thanks for the contribution. >>>> >>>> If you send me the modified file I will make a pull request from it so others can review it. Or you can create pull request yourself if you want. The process is really easy and is documented here: >>>> https://github.com/hollie/misterhouse/wiki/Contributing#creating-a-pull-request >>>> >>>> Kind regards, >>>> Lieven. >>>> >>>> Op 23-aug.-2013, om 03:45 heeft Tom <tom...@gm...> het volgende geschreven: >>>> >>>>> I've made some modifications to xbmc_notification.pl to send all >>>>> speech events to an XBMC client. >>>>> I've also made changes to allow control of the amount of time the >>>>> notification is displayed on the screen and specify an image to >>>>> display. >>>>> >>>>> >>>>> The changes are documented on the misterhouse wiki >>>>> >>>>> http://misterhouse.wikispaces.com/XBMC+Notifications >>>>> >>>>> >>>>> Feel free to additional updates.. ie: ability to send to more than one >>>>> xbmc client. :-) >>>>> >>>>> If the resident Perl experts could review these changes and check this >>>>> in to the git repository, it would be appreciated. >>>>> >>>>> thanks, >>>>> tom >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Introducing Performance Central, a new site from SourceForge and >>>>> AppDynamics. Performance Central is your source for news, insights, >>>>> analysis and resources for efficient Application Performance Management. >>>>> Visit us today! >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk >>>>> ________________________________________________________ >>>>> To unsubscribe from this list, go to: http://sourceforge.net/mail/?group_id=1365 >>>>> >>>> >> |