Re: [mh] Found data flush bug in X10_W800.pm -> proposed patch

[Marc M. <ma...@me...>]

On Wed, Apr 21, 2010 at 09:23:13AM -0700, Marc MERLIN wrote:
> I think this simple patch would fix the problem, but it almost looks too
> simple. Can someone review/give a second opinion?
> 
> Actually, Gregg, svn points you as last maintainer. Hi, I'm Marc, pleased to
> meet you :)
> 
> I make no claims I understood the entire logic and this is the right
> patch, but I think the intent was to discard packets that were left 
> over after a certain timeout, not within a timeout. Correct?
> 
> Index: lib/X10_W800.pm
> ===================================================================
> --- lib/X10_W800.pm     (revision 1710)
> +++ lib/X10_W800.pm     (working copy)
> @@ -95,7 +95,7 @@
>         # data from a corrupt data stream.
>         # NOTE: get_tickcount wraps, so $time < $new_data_time test is to
>         #       make sure that doesn't become a problem.
> -       if (&X10_W800::is_within_timeout($time, $new_data_time, 2000)) {
> +       if (not &X10_W800::is_within_timeout($time, $new_data_time, 2000)) {
>            my $hex = unpack "H*", $main::Serial_Ports{W800}{data};
>            &::print_log("W800: flushing incomplete data: $hex") if $main::Debug{w800};

Just to close the loop on this, this patch has been submitted to cvs last
week.

Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems & security ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/