From: Kirk B. <ki...@ka...> - 2003-12-14 05:35:08
|
On Sat, 13 Dec 2003, Bruce Winter wrote: > > Looks like one solution would be to pass a $source string into > > &process_serial_data, and not populate @prev_x10_events if the source was > > from a zippy interface. > > > > Any objections? Anyone think of a need to merge data from fast RF > > interfaces? > > Assuming we want to do this, lets try this. Add $source here, in bin/mh: > > my ($event_data, $prev_pass, $source) = @_; > > and here: > > unless ($prev_pass or $source eq 'rf') { > > Then add 'rf' here in lib/X10_RF.pm (to cover ther W800 and MR26 modules): > > &main::process_serial_data($state, undef, 'rf'); > > and twice in X10_W800RF.pm, if using that interface. > > I have not tried it here yet, but it should work ;) I tried this out. It does not seem to break anything. I can't say that that it definitely fixed anything either, but it makes sense. It is in my local code so I'll let you know if I have any problems. Until then, I think it is a good change to make in your code. I tried with X10_RF.pm. I do not use X10_W800RF.pm because I'm not even clear what benefit it would give me. -- Kirk Bauer <ki...@ka...> http://linux.kaybee.org | www.autorpm.org | www.logwatch.org |