#113 Add support for subtitles in Asus OPlay Mini/Mini+

Unstable (example)
closed-fixed
5
2014-03-13
2014-03-09
whosane
No

While, miniDLNA works great with the Asus O!Play Mini/Mini Plus Media Players (http://www.asus.com/Multimedia/OPlay_Mini_Plus/), subtitles do not work. However subtitles work just fine with a program called "serviio" (http://serviio.org/). A bit of debugging of the stream data showed that Asus likes to accept the subtitles as a "res" tag just like the LG TV (DIDL XML attached).
Would it be possible to add subtitle support for this player (i would ultimately like to use miniDLNA via DDWRT on DLNA capable routers.)

Patch is attached.

2 Attachments

Discussion

  • whosane
    whosane
    2014-03-09

    Note : The filename of the movie must be less than 23 characters for subtitles to work, or else the player simply reboots. I've also logged a support request with Asus (https://vip.asus.com/VIP2/Services/MailDetail/WTM20140309231643747). However, is this something we can take care of within miniDLNA itself?

     
  • Justin Maggard
    Justin Maggard
    2014-03-10

    Does the 22-character limit apply to all file types?

     
  • whosane
    whosane
    2014-03-11

    Just tried this with other file formats.
    It will reboot with avi/mp4 formats, however it works just fine with the mkv format. With mkv the subtitle in the menu shows up as "1 English". With avi/mp4 it shows up as "1 <MovieName>.srt srt" (yups, srt twice). Just to compare, if i run this of an USB the name of the subtitle shows up as "1 srt" for avi/mp4 regardless of filename. For mkv it's still "1 English".

    My previous post has a typo, the character limit is 23 characters rather than 22.

     
  • Justin Maggard
    Justin Maggard
    2014-03-11

    How about audio files? Are those limited to 23 characters as well?

    Please give this patch a try.

     
  • whosane
    whosane
    2014-03-12

    Audio files work fine regardless of length. The player does not support "subtitles/lyrics" for audio though, so i cannot test that part out.
    Video files work fine too regardless of length, it's only when using subtitles with video files with lengthy file names that the player crashes (probably too small a buffer allocated)

    The patch works perfectly though, ofcourse with the side effect of movie titles being truncated to 23 characters. I've attached snapshots of how the new movie titles appear as well as how subtitles appear.

     
  • Justin Maggard
    Justin Maggard
    2014-03-12

    Okay, how about this patch. It should only truncate titles if they have captions associated with them.

     
  • whosane
    whosane
    2014-03-13

    Yes, works great. I see that your truncating the title name only if the video has an accompanying subtitle. That would be a good feature to have. I've checked both cases to make sure neither is broken.

    Thank you very much for following up on this.

     
  • Justin Maggard
    Justin Maggard
    2014-03-13

    Thanks, pushed to master.

     
  • Justin Maggard
    Justin Maggard
    2014-03-13

    • status: open --> closed-fixed
    • assigned_to: Justin Maggard