Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

segfault trying to play music from Tivo

Hank
2011-06-26
2013-05-29
  • Hank
    Hank
    2011-06-26

    I built the latest from CVS and was playing around with Tivo support but couldn't get any music to play.  I tracked down a segfault to a change in tivo_commands.c.  Here's a patch that will get it playing again.

    --- tivo_commands.c 13 May 2011 22:10:15 -0000  1.29
    +++ tivo_commands.c 26 Jun 2011 01:40:58 -0000
    @@ -290,6 +290,7 @@
        str.data = resp;
        ret = strcatf(&str, "<?xml version='1.0' encoding='UTF-8' ?>\n<TiVoItem>");
        args.requested = 1;
    +   args.str = &str;
        asprintf(&sql, SELECT_COLUMNS
                       "from OBJECTS o left join DETAILS d on (d.ID = o.DETAIL_ID)"
                   " where o.DETAIL_ID = %lld group by o.DETAIL_ID", item);
    
     
  • Justin Maggard
    Justin Maggard
    2011-06-26

    Ah, thanks a lot for reporting this and tracking down where the problem is.  The fix has been checked in to CVS.