#231 Regression: updating from 1.1.1 to 1.1.2 breaks compatibility with Samsung D5100

v1.0 (example)
open
nobody
None
5
2014-03-11
2014-03-10
Alexandre Demers
No

Regression: by updating from 1.1.1 to 1.1.2 (Archlinux 64bit), only music files are listed on a Samsung D5100 blu-ray reader, regardless if I'm under Videos, Music or Pictures menu. However, by reverting to 1.1.1, everthing is back to normal.

While trying to figure out what was wrong with 1.1.2, I tested on my Android tablet and everthing was accessible as it should. So it seems related to an identification about capabilities between my bluray reader and MiniDLNA introduced in 1.1.2.

Discussion

1 2 > >> (Page 1 of 2)
  • I'll bisect tomorrow and I'll give you what I'll have identified.

     
  • Justin Maggard
    Justin Maggard
    2014-03-10

    Interesting, I'm eager to see what your bisect points to. I have a D-series BDP which is able to see and play videos from 1.1.2, so maybe it's related to your configuration?

     
  • First bad commit is e2c73f163d7b070145cc1a5a7853ca7431378c5f
    Author: Spencer Oliver spen@spen-soft.co.uk 2013-12-05 16:42:00
    Committer: Justin Maggard jmaggard10@gmail.com 2014-01-31 18:33:51
    Parent: ff76966a1c955f4b56737ca11e371c5a230a817c (uuid: use CLOCK_REALTIME if CLOCK_MONOTONIC not available)
    Branches: master, remotes/origin/master
    Follows: v1_1_1
    Precedes: v1_1_2

    clients: merge samsung Series C client id
    
    A Samsung TV cannot be reliably detected by checking for "SEC_HHP_TV"
    User Agent. Only the first part can be guaranteed, eg. "SEC_HHP_" as the rest
    can be changed by the end user.
    
    Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
    
     
  • Maybe a log could help?

     
  • Justin Maggard
    Justin Maggard
    2014-03-10

    Yes, please, that would be great.

     
  • Here is a 1.1.2 log

     
    Attachments
  • And here a 1.1.1 log

     
    Attachments
  • Spencer Oliver
    Spencer Oliver
    2014-03-11

    Guess this relates to FLAG_SAMSUNG_TV getting set for user agents detected as "SEC_HHP_". The previous code used the agent "SEC_HHP_TV" before it set this flag.

    The issue is how do you safely detect Samsung clients that require a different root descriptor ?

     
1 2 > >> (Page 1 of 2)