#70 IErrorInfo/ICreateErrorInfo interfaces

closed-fixed
Danny Smith
w32api (251)
2001-08-02
2001-07-02
Anonymous
No

I've found that IErrorInfo interface definition
contains a bug. Also
ICreateErrorInfo interface is missed there. So could
you apply the
following patch:

[---cut---]
--- oleidl.old Mon May 21 03:41:34 2001
+++ oleidl.h Mon Jun 25 11:17:25 2001
@@ -306,12 +306,30 @@
STDMETHOD_(ULONG,AddRef)(THIS) PURE;
STDMETHOD_(ULONG,Release)(THIS) PURE;

- STDMETHOD(GetGUID)(THIS_ REFIID) PURE;
+ STDMETHOD(GetGUID)(THIS_ GUID*) PURE;
STDMETHOD(GetSource)(THIS_ BSTR*) PURE;
STDMETHOD(GetDescription)(THIS_ BSTR*) PURE;
+ STDMETHOD(GetHelpFile)(THIS_ BSTR*) PURE;
STDMETHOD(GetHelpContext)(THIS_ DWORD*) PURE;

- };
+};
+
+EXTERN_C const IID IID_ICreateErrorInfo;
+#undef INTERFACE
+#define INTERFACE ICreateErrorInfo
+DECLARE_INTERFACE_(ICreateErrorInfo, IUnknown)
+{
+ STDMETHOD(QueryInterface)(THIS_ REFIID,PVOID*)
PURE;
+ STDMETHOD_(ULONG,AddRef)(THIS) PURE;
+ STDMETHOD_(ULONG,Release)(THIS) PURE;
+
+ STDMETHOD(SetGUID)(THIS_ REFGUID) PURE;
+ STDMETHOD(SetSource)(THIS_ LPOLESTR) PURE;
+ STDMETHOD(SetDescription)(THIS_ LPOLESTR) PURE;
+ STDMETHOD(SetHelpFile)(THIS_ LPOLESTR) PURE;
+ STDMETHOD(SetHelpContext)(THIS_ DWORD) PURE;
+
+};

#ifdef __cplusplus
}
[---cut---]

BTW, why I*ErrorInfo inteface definitions are places
into oleidl.h? MSVC
holds them in oaidl.idl/oaidl.h ...

Discussion

  • Danny Smith
    Danny Smith
    2001-07-30

    • assigned_to: nobody --> dannysmith
     
  • Danny Smith
    Danny Smith
    2001-08-02

    Logged In: YES
    user_id=11494

    Committed to SF CVS. Thanks Dmitry.

     
  • Danny Smith
    Danny Smith
    2001-08-02

    • status: open --> closed-fixed
     
  • Danny Smith
    Danny Smith
    2001-08-02

    Logged In: YES
    user_id=11494

    Sorry, the patch isn't acceptable. Hopefully there has been appropriate explanation prior to this action. If not or if
    you have further questions then please ask them at mingw-patches@lists.sourceforge.net and be sure to include the
    patch # in the subject for reference.

     
  • Danny Smith
    Danny Smith
    2001-08-02

    Logged In: YES
    user_id=11494

    Sorry, my mouse was attracted to the canned response and
    was naughty. I didn't really want to can.
    Life is like a canned response. You never know when you'll
    get a pureed slug or grub in your tomato soup.
    danny