#506 perl readline creates sys$command files w/o STDIN connected

Not_MinGW.org
closed-fixed
msys tool (1)
2012-11-26
2012-01-01
No

perl Term/ReadLine.pm creates empty sys$command files if no STDIN is connected (example http://code.google.com/p/tortoisegit/issues/detail?id=1011\).

I noticed this issue on using msysgit with TortoiseGit. I tracked down which msysgit versions are affected (<=1.7.7 work, but >=1.7.7.1 has the issue), but both use the same perl versions (5.8.8) and Termin/Readline.pl (1.02). I don't know how this issue was introduced, but the reason seems to be that there is no "con"-file and $^O is 'msys', but a check is missing for this (in Term/ReadLine.pm, sub findConsole, line 214).

Discussion

  •  
    Attachments
  • Răzvan Panda
    Răzvan Panda
    2012-11-15

    Any update on this bug? I am using:
    TortoiseGIT 1.7.14.0
    git version 1.8.0.msysgit.0
    and sys$command is still created when I do a git svn fetch for example.

     
  • Earnie Boyd
    Earnie Boyd
    2012-11-15

    I'm assigning this to Chuck for review. My original thought was to close as won't fix since this is related to perl, the patch is against the perl pacakge, and the tools being used aren't distributed by MinGW.org. In the end I decided to leave it open and assigned.

     
  • Earnie Boyd
    Earnie Boyd
    2012-11-15

    • labels: 739052 --> msys tool
    • milestone: --> Not_MinGW.org
    • assigned_to: nobody --> cwilso11
     
  • Robert Pollak
    Robert Pollak
    2012-11-21

    So should this issue be filed at rt.perl.org instead?

     
  • Patch applied upstream.

     
  • Earnie Boyd
    Earnie Boyd
    2012-11-26

    • status: open --> closed-fixed
     
  • Earnie Boyd
    Earnie Boyd
    2012-11-26

    Thanks for the update.