#499 Missing constants for getaddrinfo

License_conflict
closed-invalid
w32api (251)
2011-12-06
2011-10-31
thomas
No

Some constants that are supported beginning with Vista are missing (nb: it does not cause an error to use them under XP, they're just ignored).

Add to ws2tcpip.h, line 107:

#if WINVER >= _WIN32_WINNT_VISTA
#define AI_NUMERICSERV 0x00000008
#define AI_ALL 0x00000100
#define AI_ADDRCONFIG 0x00000400
#define AI_V4MAPPED 0x00000800

\#define AI\_NON\_AUTHORITATIVE 0x00004000
\#define AI\_SECURE 0x00008000
\#define AI\_RETURN\_PREFERRED\_NAMES 0x00010000

#endif

Discussion

  • Earnie Boyd
    Earnie Boyd
    2011-12-01

    Please provide the MSDN reference for these constants.

     
  • Earnie Boyd
    Earnie Boyd
    2011-12-01

    • assigned_to: nobody --> ir0nh34d
     
  • Earnie Boyd
    Earnie Boyd
    2011-12-02

    • milestone: --> License_conflict
    • status: open --> pending-invalid
     
  • Earnie Boyd
    Earnie Boyd
    2011-12-02

    I suspect that you've determined the values from the SDK source and copied and pasted from it. This cannot be allowed. We don't even have _WIN32_WINNT_VISTA defined.

     
  • thomas
    thomas
    2011-12-06

    The suspicion is wrong. I found out the values by browsing ReactOS headers on Google code search and, as far as they exist in both, cross-checking them with a Linux-glibc header equally browsable on the Google site. No Microsoft SDK present on my machine. The origin of _WIN32_WINNT_VISTA is the "Using the Windows Headers" page on MSDN which lists this value as the macro to be used for upwards of Windows Vista (I apologize for not verifying that MinGW supports the standard defines, feel free to use the value 0x600 instead, or turn the patch down, or whatever).

     
  • thomas
    thomas
    2011-12-06

    • status: pending-invalid --> open-invalid
     
  • Earnie Boyd
    Earnie Boyd
    2011-12-06

    • status: open-invalid --> closed-invalid
     
  • Earnie Boyd
    Earnie Boyd
    2011-12-06

    Browsing ReactOS or Wine or glibc is also wrong. Sorry this patch cannot be accepted because of license breaches. We cannot contaminate our source with other licenses.