Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#437 mingw-get: Check for needed header files.

Patch_committed
closed-accepted
mingw-get (5)
2010-04-17
2010-03-28
Cesar Strauss
No

The src/pkgstrm.h file includes a few headermingw-get: files from external libraries unconditionally. To avoid a potential failure at compile time, check for the existence of these header files at configure time.

Discussion

  • Cesar Strauss
    Cesar Strauss
    2010-03-28

    Sorry for the garbled description. Resend.

    The src/pkgstrm.h file includes a few header files from external
    libraries unconditionally. To avoid a potential failure at compile time,
    check for the existence of these header files at configure time.

     
  • Keith Marshall
    Keith Marshall
    2010-03-29

    Thanks Cesar.

    I'd planned to include such a check, ultimately, but more likely following the autoconf paradigm used by groff to identify missing prerequisites; (its advantage is that all the missing prerequisites are itemised in a single abort message from a single configure run). However, as an interim measure, I see no reason why your patch won't suffice.

     
  • Keith Marshall
    Keith Marshall
    2010-04-17

    I decided to adopt the more comprehensive strategy from the outset; see CVS commits during late evening UTC on 2010-04-17.

     
  • Keith Marshall
    Keith Marshall
    2010-04-17

    • labels: --> mingw-get
    • milestone: --> Patch_committed
    • assigned_to: nobody --> keithmarshall
    • status: open --> closed-accepted
     
  • Keith Marshall
    Keith Marshall
    2010-04-18

    > I decided to adopt the more comprehensive strategy from the outset...

    Except that I omitted the final piece of the jig-saw; now corrected.