Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#229 MSYS.BAT fix for bug #1011360

closed-accepted
Earnie Boyd
msys (22)
2005-07-06
2005-05-15
No

This is a patch to MSYS.BAT to fix the problem
described in bug report #1011360. The basic change is
to test for the existance of the key msys-1.0.dll file
rather than on the arbitrary content of an
environmental variable.

There are two additional changes:

1) The intermediate DOS window in the sequence is
minimized so it no longer clutters up the screen during
MSYS startup.

2) If rxvt.exe can not be found, an attempt is made to
start sh.exe before putting out an error message.

Please let me know if this is the correct form for patches.

Discussion

  • Patch to MSYS.BAT to fix bug #1011360.

     
    Attachments
  • Earnie Boyd
    Earnie Boyd
    2005-05-18

    • labels: --> msys
     
  • Earnie Boyd
    Earnie Boyd
    2005-05-18

    Logged In: YES
    user_id=15438

    Can you please use -u3 for the diff?

     
  • Earnie Boyd
    Earnie Boyd
    2005-05-18

    • assigned_to: nobody --> earnie
     
  • Again

     
    Attachments
  • Logged In: YES
    user_id=735003

    In -u3 format per your request...

     
  • Earnie Boyd
    Earnie Boyd
    2005-05-22

    Logged In: YES
    user_id=15438

    I don't see the /m option to start in the help! What does
    it do?

    c:\mnt\home\BoydE>help start
    help start
    Starts a separate window to run a specified program or command.

    START ["title"] [/Dpath] [/I] [/MIN] [/MAX] [/SEPARATE |
    /SHARED]
    [/LOW | /NORMAL | /HIGH | /REALTIME | /ABOVENORMAL |
    /BELOWNORMAL]
    [/WAIT] [/B] [command/program]
    [parameters]

     
  • Logged In: YES
    user_id=735003

    C:\WINDOWS>start /?
    Runs a Windows program or an MS-DOS program.

    START [options] program [arg...]
    START [options] document.ext

    /m[inimized] Run the new program minimized (in the background).
    /max[imized] Run the new program maximized (in the foreground).
    /r[estored] Run the new program restored (in the
    foreground). [default]
    /w[ait] Does not return until the other program exits.

     
  • Earnie Boyd
    Earnie Boyd
    2005-05-23

    Logged In: YES
    user_id=15438

    Does /min work for you? /m isn't on XP.

    I don't know that I want to start minimized. I know the
    effect it will present. I'm considering it.

     
  • Logged In: YES
    user_id=735003

    Not a problem.

    But note that:

    1) Unless XP uses command.com with it's eight byte label
    limit, it will never see this line.

    2) This is an intermediate window that normally flashes on
    the screen briefly and disapears in order to assure adaqute
    environment space. The later lines that do the real work
    can not use this feature.

    3) This is purely cosmentic. The important changes are the
    EXIST tests.

    I've never opened my XP-pro distribution so I have not
    tested this under XP.

     
  • Earnie Boyd
    Earnie Boyd
    2005-07-06

    • milestone: --> IINR_-_Include_In_Next_Release
    • status: open --> closed-accepted